From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Date: Sat, 23 May 2015 18:27:54 +0200 Subject: [U-Boot] [PATCH v2] wandboard: Add board revision detection support In-Reply-To: <87siaob018.fsf@aikidev.net> References: <1432247045-17518-1-git-send-email-festevam@gmail.com> <87siaob018.fsf@aikidev.net> Message-ID: <5560AA8A.8010601@ahsoftware.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 23.05.2015 um 02:38 schrieb Vagrant Cascadian: > On 2015-05-21, Fabio Estevam wrote: >> From: Fabio Estevam >> >> There are two revisions of wandboard: version B1 and C1. >> >> Add the revision detection support, so that the correct dtb file can >> be automatically loaded. >> >> Based on the patch from Richard Hu . >> >> Signed-off-by: Fabio Estevam > > Tested on a Wandboard dual (rev c1) and wandboard quad (rev b1). > > Tested-By: Vagrant Cascadian > >> --- >> Changes since v1: >> >> - Fixed commit log to 'automatically loaded'. >> >> board/wandboard/wandboard.c | 26 +++++++++++++++++++++++++- >> include/configs/wandboard.h | 8 ++++++-- Wouldn't it be better to just enable CONFIG_CMD_GPIO and then change the boot-script in the config to something like "if gpio ..." instead of adding something special? Assuming the gpio command works on imx, which I haven't tested or looked up. Regards, Alexander Holler