From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sun, 24 May 2015 09:43:29 +0200 Subject: [U-Boot] [PATCH v2] wandboard: Add board revision detection support In-Reply-To: <5560AA8A.8010601@ahsoftware.de> References: <1432247045-17518-1-git-send-email-festevam@gmail.com> <87siaob018.fsf@aikidev.net> <5560AA8A.8010601@ahsoftware.de> Message-ID: <55618121.4020300@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, Alexander, On 23/05/2015 18:27, Alexander Holler wrote: > Am 23.05.2015 um 02:38 schrieb Vagrant Cascadian: >> On 2015-05-21, Fabio Estevam wrote: >>> From: Fabio Estevam >>> >>> There are two revisions of wandboard: version B1 and C1. >>> >>> Add the revision detection support, so that the correct dtb file can >>> be automatically loaded. >>> >>> Based on the patch from Richard Hu . >>> >>> Signed-off-by: Fabio Estevam >> >> Tested on a Wandboard dual (rev c1) and wandboard quad (rev b1). >> >> Tested-By: Vagrant Cascadian >> >>> --- >>> Changes since v1: >>> >>> - Fixed commit log to 'automatically loaded'. >>> >>> board/wandboard/wandboard.c | 26 +++++++++++++++++++++++++- >>> include/configs/wandboard.h | 8 ++++++-- > > Wouldn't it be better to just enable CONFIG_CMD_GPIO and then change the > boot-script in the config to something like "if gpio ..." instead of > adding something special? > > Assuming the gpio command works on imx, which I haven't tested or looked > up. gpio works - this is really a good idea, moving the check into the script. Fabio, what do you mind ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================