From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sun, 24 May 2015 16:30:24 +0200 Subject: [U-Boot] [PATCH v2] wandboard: Add board revision detection support In-Reply-To: References: <1432247045-17518-1-git-send-email-festevam@gmail.com> <87siaob018.fsf@aikidev.net> <5560AA8A.8010601@ahsoftware.de> <55618121.4020300@denx.de> Message-ID: <5561E080.5060009@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, On 24/05/2015 16:27, Fabio Estevam wrote: > > I think the idea is good, thanks. > > I wanted to keep consistency with the mx6cuboxi implementation (which > was based on TI's implementation suggested by Tom during the review of > the mx6cuboxi patches). > > Also, the gpio script idea would work fine for selecting the dtb file, > but not inside checkboard() function, where I print the board revision > name. > > Other aspect I thought is the fact that in case we have another > revision of the board in the future, I think that C code is more > flexible for handling it. This is a good point, thanks. > > So I like the idea of gpio script, but I would prefer to keep the > current implementation if possible due to the reasons stated above. > ok, clear enough - on my site it is ok to maintain current implementation. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================