From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 26 May 2015 13:39:42 +0200 Subject: [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h In-Reply-To: <555F7302.1060609@web.de> References: <555F7302.1060609@web.de> Message-ID: <55645B7E.3000107@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Soeren, On 22/05/2015 20:18, Soeren Moch wrote: >> All boards define CONFIG_MX6, CONFIG_DISPLAY_BOARDINFO, >> CONFIG_DISPLAY_CPUINFO >> and CONFIG_SYS_GENERIC_BOARD so define them in mx6_common >> >> Signed-off-by: Peter Robinson >> Reviewed-by: Tom Rini > > Some boards defineCONFIG_DISPLAY_BOARDINFO_LATE (instead of > CONFIG_DISPLAY_BOARDINFO) to also see this info on HDMI. > > So please add CONFIG_DISPLAY_BOARDINFO_LATE to mx6_common.h > > Sorry, I missed this in the last review round. As far as I can see, there are only two boards : gw_ventana and tbs2910. CONFIG_DISPLAY_BOARDINFO_LATE enables show_board_info(), and this is not weak, printing twice if we have both CONFIG_DISPLAY_BOARDINFO_LATE and CONFIG_DISPLAY_BOARDINFO. I would suggest that we add #undef CONFIG_DISPLAY_BOARDINFO #define CONFIG_DISPLAY_BOARDINFO_LATE to gw_ventana.h and tbs2910.h after applying this series. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================