public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] pwm: imx: Remove unreachable code
Date: Tue, 26 May 2015 14:14:25 +0200	[thread overview]
Message-ID: <556463A1.1060208@denx.de> (raw)
In-Reply-To: <1432365450.17001.1.camel@ingics.com>

On 23/05/2015 09:17, Axel Lin wrote:
> The break after return is unreachable code, remove it.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/pwm/pwm-imx-util.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-imx-util.c b/drivers/pwm/pwm-imx-util.c
> index 79d86028..f92c370 100644
> --- a/drivers/pwm/pwm-imx-util.c
> +++ b/drivers/pwm/pwm-imx-util.c
> @@ -21,16 +21,12 @@ struct pwm_regs *pwm_id_to_reg(int pwm_id)
>  	switch (pwm_id) {
>  	case 0:
>  		return (struct pwm_regs *)PWM1_BASE_ADDR;
> -		break;
>  	case 1:
>  		return (struct pwm_regs *)PWM2_BASE_ADDR;
> -		break;
>  	case 2:
>  		return (struct pwm_regs *)PWM3_BASE_ADDR;
> -		break;
>  	case 3:
>  		return (struct pwm_regs *)PWM4_BASE_ADDR;
> -		break;
>  	default:
>  		printf("unknown pwm_id: %d\n", pwm_id);
>  		break;
> 
Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2015-05-26 12:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23  7:16 [U-Boot] [PATCH 1/2] pwm: imx: Prevent NULL pointer dereference Axel Lin
2015-05-23  7:17 ` [U-Boot] [PATCH 2/2] pwm: imx: Remove unreachable code Axel Lin
2015-05-23 10:22   ` Stefano Babic
2015-05-26  4:27   ` Heiko Schocher
2015-05-26 12:14   ` Stefano Babic [this message]
2015-05-23 10:22 ` [U-Boot] [PATCH 1/2] pwm: imx: Prevent NULL pointer dereference Stefano Babic
2015-05-26  4:27 ` Heiko Schocher
2015-05-26 12:14 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556463A1.1060208@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox