From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/20] armv8/ls2085aqds: Add support of 0x49 in ethernet
Date: Tue, 26 May 2015 08:51:52 -0700 [thread overview]
Message-ID: <55649698.3060005@freescale.com> (raw)
In-Reply-To: <1431932937-10120-4-git-send-email-prabhakar@freescale.com>
Prabhakar,
On 05/18/2015 12:08 AM, Prabhakar Kushwaha wrote:
> Add support of 0x49 SerDes protocol for ls2085aqds platform
>
I would change the subject to "Add support of SerDes protocol 0x49". If you
want, you can put in commit message to explain what 0x49 does. Unless one is
familiar with SerDes protocols, it wouldn't be easy to link 0x49 to Ethernet.
York
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> board/freescale/ls2085aqds/eth.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/freescale/ls2085aqds/eth.c b/board/freescale/ls2085aqds/eth.c
> index 5ba4770..f32ace2 100644
> --- a/board/freescale/ls2085aqds/eth.c
> +++ b/board/freescale/ls2085aqds/eth.c
> @@ -210,6 +210,7 @@ static void initialize_dpmac_to_slot(void)
> switch (serdes2_prtcl) {
> case 0x07:
> case 0x08:
> + case 0x49:
> printf("qds: WRIOP: Supported SerDes Protocol 0x%02x\n",
> serdes2_prtcl);
> lane_to_slot_fsm2[0] = EMI1_SLOT4;
> @@ -247,6 +248,7 @@ void ls2085a_handle_phy_interface_sgmii(int dpmac_id)
> switch (serdes2_prtcl) {
> case 0x07:
> case 0x08:
> + case 0x49:
> lane = serdes_get_first_lane(FSL_SRDS_2, SGMII9 +
> (dpmac_id - 9));
> slot = lane_to_slot_fsm2[lane];
>
next prev parent reply other threads:[~2015-05-26 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 7:08 [U-Boot] [PATCH 01/20] armv8/ls2085ardb: Add eth & phy f/w loading support Prabhakar Kushwaha
2015-05-18 7:08 ` [U-Boot] [PATCH 02/20] armv8/ls2085ardb: add hwconfig setting for eSDHC Prabhakar Kushwaha
2015-05-18 7:08 ` [U-Boot] [PATCH 03/20] armv8/ls2085a: Enable Date command for QDS and RDB Prabhakar Kushwaha
2015-05-18 7:08 ` [U-Boot] [PATCH 04/20] armv8/ls2085aqds: Add support of 0x49 in ethernet Prabhakar Kushwaha
2015-05-26 15:51 ` York Sun [this message]
2015-05-18 7:08 ` [U-Boot] [PATCH 05/20] armv8/ls2085a: call ft_pcie_setup() to change dts status Prabhakar Kushwaha
2015-05-26 15:54 ` York Sun
2015-05-27 3:40 ` Lian M.H.
2015-05-27 4:30 ` Kushwaha Prabhakar
2015-05-27 15:27 ` York Sun
2015-05-18 7:08 ` [U-Boot] [PATCH 06/20] armv8/ls2085qds: Update SFP TX bit as "0" to enable XFI Prabhakar Kushwaha
2015-05-18 7:08 ` [U-Boot] [PATCH 07/20] armv8/ls2085rdb: Update PCA9547PW slave address Prabhakar Kushwaha
2015-05-26 15:55 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55649698.3060005@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox