[U-Boot] [PATCH 05/20] armv8/ls2085a: call ft_pcie_setup() to change dts status

Lian M.H.
2015-05-27T03:40:45Z

Hi York,

1. board/freescale/ls2085a/ls2085a.c is for board ls2085a_emu like ls2085aqds.c not SoC file.
But I am not sure whether emulator board should call this function.
2. ft_pcie_setup(blob, bd) should be changed to ft_pci_setup(blob, bd)
ft_pci_setup is the common function name defined in common.h

Thanks,
Minghuan

> -----Original Message-----
> From: Sun York-R58495
> Sent: Tuesday, May 26, 2015 11:54 PM
> To: Kushwaha Prabhakar-B32579; u-boot at lists.denx.de
> Cc: Lian Minghuan-B31939
> Subject: Re: [PATCH 05/20] armv8/ls2085a: call ft_pcie_setup() to change dts
> status
>
> Prabhakar and Minghuan,
>
> On 05/18/2015 12:08 AM, Prabhakar Kushwaha wrote:
> > From: Minghuan Lian <Minghuan.Lian@freescale.com>
> >
> > 1. The patch call ft_pcie_setup() to disable PCIe dts node if
> > corresponding PCIe controller is disabled according to RCW.
> > 2. Fix LS2085a PCIe compatible
> >
> > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > ---
> > board/freescale/ls2085a/ls2085a.c | 4 ++++
> > board/freescale/ls2085aqds/ls2085aqds.c | 4 ++++
> > board/freescale/ls2085ardb/ls2085ardb.c | 4 ++++
> > include/configs/ls2085a_common.h | 3 ++-
> > 4 files changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/board/freescale/ls2085a/ls2085a.c
> > b/board/freescale/ls2085a/ls2085a.c
> > index dd0acf2..afb99d1 100644
> > --- a/board/freescale/ls2085a/ls2085a.c
> > +++ b/board/freescale/ls2085a/ls2085a.c
> > @@ -142,6 +142,10 @@ int ft_board_setup(void *blob, bd_t *bd)
> > fsl_mc_ldpaa_exit(bd);
> > #endif
> >
> > +#ifdef CONFIG_PCI
> > + ft_pcie_setup(blob, bd);
> > +#endif
> > +
>
> Shouldn't this function be called from SoC function? It is not a board-
> dependent setup, but rather depending on RCW which is an SoC feature.
>
> York