public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] zynqmp: gem: Set data bus with to 64bit for arm64
Date: Thu, 28 May 2015 09:01:53 +0200	[thread overview]
Message-ID: <5566BD61.5070904@xilinx.com> (raw)
In-Reply-To: <CANr=Z=aMoYAugguFAbESEip26dQPu3SAoSLg2JeC0jjqKyfKiQ@mail.gmail.com>

On 05/27/2015 08:08 PM, Joe Hershberger wrote:
> Hi Michal,
> 
> On Tue, May 26, 2015 at 6:40 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>>
>> Set the data bus width to 64-bit AMBA Databus width in config register.
>>
>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  drivers/net/zynq_gem.c | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
>> index c723dbb0a694..22195805e6d6 100644
>> --- a/drivers/net/zynq_gem.c
>> +++ b/drivers/net/zynq_gem.c
>> @@ -58,7 +58,14 @@
>>  #define ZYNQ_GEM_NWCFG_MDCCLKDIV       0x000080000 /* Div pclk by 32, 80MHz */
>>  #define ZYNQ_GEM_NWCFG_MDCCLKDIV2      0x0000c0000 /* Div pclk by 48, 120MHz */
>>
>> -#define ZYNQ_GEM_NWCFG_INIT            (ZYNQ_GEM_NWCFG_FDEN | \
>> +#ifdef CONFIG_TARGET_XILINX_ZYNQMP
> 
> Isn't there a more explicit define you can use to select this such as
> CONFIG_ARM64?

No problem to use it - fixed in v2.

> 
>> +# define ZYNQ_GEM_DBUS_WIDTH   (1 << 21) /* 64 bit bus */
>> +#else
>> +# define ZYNQ_GEM_DBUS_WIDTH   (0 << 21) /* 32 bit bus */
>> +#endif
>> +
>> +#define ZYNQ_GEM_NWCFG_INIT            (ZYNQ_GEM_DBUS_WIDTH | \
>> +                                       ZYNQ_GEM_NWCFG_FDEN | \
>>                                         ZYNQ_GEM_NWCFG_FSREM | \
>>                                         ZYNQ_GEM_NWCFG_MDCCLKDIV)
> 
> There is a typo in the subject.  with->width.

Fixed too in v2.

Thanks,
Michal

      reply	other threads:[~2015-05-28  7:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 11:40 [U-Boot] [PATCH 1/4] zynqmp: gem: Set data bus with to 64bit for arm64 Michal Simek
2015-05-26 11:40 ` [U-Boot] [PATCH 2/4] zynqmp: gem: Flush the rx buffers while transmitting Michal Simek
2015-05-26 11:40 ` [U-Boot] [PATCH 3/4] zynq: gem: Increase the Rx buffer descriptors to 32 Michal Simek
2015-05-26 11:40 ` [U-Boot] [PATCH 4/4] zynq: gem: Setting up WRAP bit for one TX bd Michal Simek
2015-05-27 18:08 ` [U-Boot] [PATCH 1/4] zynqmp: gem: Set data bus with to 64bit for arm64 Joe Hershberger
2015-05-28  7:01   ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5566BD61.5070904@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox