From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 29 May 2015 07:28:30 +0200 Subject: [U-Boot] [PATCH] imx: missing CONFIG_NET after consolidation patches In-Reply-To: References: <1432718959-28198-1-git-send-email-sbabic@denx.de> Message-ID: <5567F8FE.9090206@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Joe, Am 28.05.2015 19:53, schrieb Joe Hershberger: > Hi Stefano, > > On Wed, May 27, 2015 at 4:29 AM, Stefano Babic wrote: >> commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 >> "Use env callbacks for net variables" has a side effect >> on i.MX6 boards because they do not set CONFIG_NET: >> the ip address results not set, but it is stored >> in the environment. >> >> => pri ipaddr >> ipaddr=192.168.178.66 >> => ping 192.168.178.1 >> *** ERROR: `ipaddr' not set >> ping failed; host 192.168.178.1 is not alive >> >> Setting CONFIG_NET solves this issue. >> >> Reported-by: Heiko Schoker >> Signed-off-by: Stefano Babic >> --- >> include/configs/mx6_common.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h >> index 233c6d2..3d859cf 100644 >> --- a/include/configs/mx6_common.h >> +++ b/include/configs/mx6_common.h >> @@ -105,4 +105,7 @@ >> #define CONFIG_FSL_ESDHC >> #define CONFIG_FSL_USDHC >> >> +/* NET */ >> +#define CONFIG_NET > > This config was added to Kconfig here: > 60296a8 commands: add more command entries in Kconfig > Author: Masahiro Yamada > Date: Thu Nov 13 19:29:08 2014 +0900 > > Apparently some of the boards that supported NET previously were not > properly added to their defconfigs. > > In any case, for this board, you should add the NET config to the > defconfig, not the header. Hmm.. this seems missing for all imx boards ... $ grep -lr CONFIG_NET configs | xargs grep MX $ bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany