From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 29 May 2015 09:14:02 +0200 Subject: [U-Boot] [U-Boot, v3, 1/4] Kconfig: Enable usage of escape char '\' in string values In-Reply-To: <20150527215849.GD18689@bill-the-cat> References: <1431950912-17213-2-git-send-email-sr@denx.de> <20150527215849.GD18689@bill-the-cat> Message-ID: <556811BA.6000309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27.05.2015 23:58, Tom Rini wrote: > On Mon, May 18, 2015 at 02:08:21PM +0200, Stefan Roese wrote: > >> I might have missed something, but I failed to use the escape char '\' >> in strings. To pass a printf format string like "foo %d bar\n" via >> Kconfig to the code. >> >> Right now its not possible to use the escape character '\' in Kconfig >> string values correctly to e.g. set this string value "test output\n". >> The '\n' will be converted to 'n'. >> >> The current implementation removes some of the '\' chars from the input >> string in conf_set_sym_val(). Examples: >> >> '\' -> '' >> '\\' -> '\' >> '\\\' -> '\' >> '\\\\' -> '\\' >> ... >> >> And then doubles the backslash chars in the output string in >> sym_escape_string_value(). Example: >> >> '\' -> '' -> '' >> '\\' -> '\' -> '\\' >> '\\\' -> '\' -> '\\' >> '\\\\' -> '\\' -> '\\\\' >> ... >> >> As you see in these examples, its impossible to generate a single '\' >> charater in the output string as its needed for something like '\n'. >> >> This patch now changes this behavior to not drop some backslashes in >> conf_set_sym_val() and to not add new backslashes in the resulting >> output string. Removing the function sym_escape_string_value() >> completely as its not needed anymore. >> >> Signed-off-by: Stefan Roese >> Cc: Masahiro Yamada >> Cc: Simon Glass >> Reviewed-by: Simon Glass > > This breaks a number of configs such as TZX-Q8-713B7_defconfig: > *** Error in `scripts/kconfig/conf': free(): invalid next size (fast): > 0x0000000002972420 *** > ../scripts/kconfig/Makefile:111: recipe for target 'TZX-Q8-713B7_defconfig' failed Hmmm. I've not seen this error while running buildman for all ARM boards. Sorry about that. I'll work on a new version later today. Thanks, Stefan