From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 01 Jun 2015 09:45:01 +0200 Subject: [U-Boot] [PATCH 09/11] colibri_vf: Add separate defconfig for device tree support In-Reply-To: <1431954389-6433-10-git-send-email-bhuvanchandra.dv@toradex.com> References: <1431954389-6433-1-git-send-email-bhuvanchandra.dv@toradex.com> <1431954389-6433-10-git-send-email-bhuvanchandra.dv@toradex.com> Message-ID: <556C0D7D.8010009@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bhuvanchandra, On 18/05/2015 15:06, Bhuvanchandra DV wrote: > Most of the drivers available for Vybrid are not yet converted > to OF model to use device tree model, only few drivers > like SPI and GPIO drivers use device trees. > Add separate defconfig for who needs to use device tree model. > Later this can be integrated to single defconfig. > > Signed-off-by: Bhuvanchandra DV > --- > configs/colibri_vf_dtb_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > create mode 100644 configs/colibri_vf_dtb_defconfig > > diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig > new file mode 100644 > index 0000000..28ff1e9 > --- /dev/null > +++ b/configs/colibri_vf_dtb_defconfig > @@ -0,0 +1,6 @@ > +CONFIG_ARM=y > +CONFIG_TARGET_COLIBRI_VF=y > +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_IS_IN_NAND,IMX_NAND" > +CONFIG_DM=y > +CONFIG_OF_CONTROL=y > +CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri" > This patch is broken because NAND setup is missing and the board colibri_vf_dtp is not built. Indeed, it is fixed with: diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig index 28ff1e9..88ecbdc 100644 --- a/configs/colibri_vf_dtb_defconfig +++ b/configs/colibri_vf_dtb_defconfig @@ -4,3 +4,5 @@ CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_I CONFIG_DM=y CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri" +CONFIG_NAND_VF610_NFC=y +CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y Please add these to your patch and resubmit, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================