[U-Boot] [PATCH V2 08/11] colibri-vf: Enable SPI support

[Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>]

Hello Stefan,

On 06/01/2015 04:02 PM, Stefan Agner wrote:
> On 2015-06-01 10:51, Bhuvanchandra DV wrote:
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>>   include/configs/colibri_vf.h | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/include/configs/colibri_vf.h b/include/configs/colibri_vf.h
>> index 195102b..3e57417 100644
>> --- a/include/configs/colibri_vf.h
>> +++ b/include/configs/colibri_vf.h
>> @@ -272,4 +272,15 @@
>>   #define CONFIG_USB_GADGET_MASS_STORAGE
>>   #define CONFIG_CMD_USB_MASS_STORAGE
>>
>> +/* Enable SPI support */
>> +#define CONFIG_DM_SPI
>> +#define CONFIG_CMD_SPI
>> +#define CONFIG_FSL_DSPI
>> +
>> +#ifndef CONFIG_OF_CONTROL
>> +#undef CONFIG_DM_SPI
>> +#undef CONFIG_CMD_SPI
>> +#undef CONFIG_FSL_DSPI
>> +#endif
>> +
>>   #endif /* __CONFIG_H */
>
> Hm, any specific reason we need to define them unconditionally first?
 >
> Couldn't we just inverse the logic and safe the undefs?
>
> #ifdef CONFIG_OF_CONTROL
> #define CONFIG_DM_SPI
> #define CONFIG_CMD_SPI
> #define CONFIG_FSL_DSPI
> #endif
>
Agreed to inverse the logic, as in both the above cases DSPI support is 
enabled by default when OF_CONTROL was defined. Your suggestion sounds 
good. Will update it accordingly, thanks!

> --
> Stefan
>

Best regards,
Bhuvan