[U-Boot] [PATCH] net: Fix NET_RANDOM_ETHADDR dependencies

[U-Boot] [PATCH] net: Fix NET_RANDOM_ETHADDR dependencies

[Michal Simek]

NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to
Kconfig to ensure that library is also compiled.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 lib/Kconfig | 3 +++
 net/Kconfig | 1 +
 2 files changed, 4 insertions(+)

diff --git a/lib/Kconfig b/lib/Kconfig
index 5b6cf3d68df1..3c8de869b1f6 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -44,6 +44,9 @@ config REGEX
 	  regex support to some commands, for example "env grep" and
 	  "setexpr".
 
+config LIB_RAND
+	bool
+
 source lib/rsa/Kconfig
 
 menu "Hashing Support"
diff --git a/net/Kconfig b/net/Kconfig
index 524b7e4da23b..9a9846e18744 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -10,6 +10,7 @@ if NET
 
 config NET_RANDOM_ETHADDR
 	bool "Random ethaddr if unset"
+	select LIB_RAND
 	help
 	  Selecting this will allow the Ethernet interface to function
 	  even when the ethaddr variable for that interface is unset.
-- 
2.3.5

[U-Boot] [PATCH] net: Fix NET_RANDOM_ETHADDR dependencies

[Joe Hershberger]

Hi Michal,

On Mon, May 25, 2015 at 4:37 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to
> Kconfig to ensure that library is also compiled.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

I'll pull this in a few days if Tom doesn't get there first.

Thanks,
-Joe

[U-Boot] [PATCH] net: Fix NET_RANDOM_ETHADDR dependencies

[Joe Hershberger]

On Mon, May 25, 2015 at 4:37 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to
> Kconfig to ensure that library is also compiled.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---

Applied to u-boot-net, thanks!
-Joe

[U-Boot] [PATCH] net: Fix NET_RANDOM_ETHADDR dependencies

[Joe Hershberger]

Hi Michal,

On Mon, May 25, 2015 at 4:37 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to
> Kconfig to ensure that library is also compiled.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  lib/Kconfig | 3 +++
>  net/Kconfig | 1 +
>  2 files changed, 4 insertions(+)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 5b6cf3d68df1..3c8de869b1f6 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -44,6 +44,9 @@ config REGEX
>           regex support to some commands, for example "env grep" and
>           "setexpr".
>
> +config LIB_RAND
> +       bool
> +
>  source lib/rsa/Kconfig
>
>  menu "Hashing Support"
> diff --git a/net/Kconfig b/net/Kconfig
> index 524b7e4da23b..9a9846e18744 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -10,6 +10,7 @@ if NET
>
>  config NET_RANDOM_ETHADDR
>         bool "Random ethaddr if unset"
> +       select LIB_RAND
>         help
>           Selecting this will allow the Ethernet interface to function
>           even when the ethaddr variable for that interface is unset.

Do you want me to run the moveconfig tool on this? I have a feeling it
will just conflict anyway if not run on top of my other 2 patches for
the defconfigs.

Cheers,
-Joe

[U-Boot] [PATCH] net: Fix NET_RANDOM_ETHADDR dependencies

[Michal Simek]

On 06/01/2015 04:06 PM, Joe Hershberger wrote:
> Hi Michal,
> 
> On Mon, May 25, 2015 at 4:37 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to
>> Kconfig to ensure that library is also compiled.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  lib/Kconfig | 3 +++
>>  net/Kconfig | 1 +
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index 5b6cf3d68df1..3c8de869b1f6 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -44,6 +44,9 @@ config REGEX
>>           regex support to some commands, for example "env grep" and
>>           "setexpr".
>>
>> +config LIB_RAND
>> +       bool
>> +
>>  source lib/rsa/Kconfig
>>
>>  menu "Hashing Support"
>> diff --git a/net/Kconfig b/net/Kconfig
>> index 524b7e4da23b..9a9846e18744 100644
>> --- a/net/Kconfig
>> +++ b/net/Kconfig
>> @@ -10,6 +10,7 @@ if NET
>>
>>  config NET_RANDOM_ETHADDR
>>         bool "Random ethaddr if unset"
>> +       select LIB_RAND
>>         help
>>           Selecting this will allow the Ethernet interface to function
>>           even when the ethaddr variable for that interface is unset.
> 
> Do you want me to run the moveconfig tool on this? I have a feeling it
> will just conflict anyway if not run on top of my other 2 patches for
> the defconfigs.

Definitely feel free to run it yourself.

Thanks,
Michal