public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] image-fit: Fix compiler warning in fit_conf_print()
Date: Sat, 06 Jun 2015 11:33:45 +0200	[thread overview]
Message-ID: <5572BE79.4060200@redhat.com> (raw)
In-Reply-To: <1432904988-32233-1-git-send-email-hdegoede@redhat.com>

Hi All,

On 29-05-15 15:09, Hans de Goede wrote:
> This fixes the following compiler warning:
>
> In file included from tools/common/image-fit.c:1:0:
> ./tools/../common/image-fit.c: In function ?fit_conf_print?:
> ./tools/../common/image-fit.c:1470:27: warning: logical not is only applied
>   to the left hand side of comparison [-Wlogical-not-parentheses]
>      (const char **)&uname) > 0;

ping? it would be nice to get this fixed, as it is the only compiler warning
I see when building u-boot.

Tom, can you pick this one up directly perhaps?

Regards,

Hans


>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   common/image-fit.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/image-fit.c b/common/image-fit.c
> index 4bd8fea..28f7aa8 100644
> --- a/common/image-fit.c
> +++ b/common/image-fit.c
> @@ -1464,10 +1464,10 @@ void fit_conf_print(const void *fit, int noffset, const char *p)
>
>   	/* Print out all of the specified loadables */
>   	for (loadables_index = 0;
> -	     !fdt_get_string_index(fit, noffset,
> +	     fdt_get_string_index(fit, noffset,
>   			FIT_LOADABLE_PROP,
>   			loadables_index,
> -			(const char **)&uname) > 0;
> +			(const char **)&uname) == 0;
>   	     loadables_index++)
>   	{
>   		if (loadables_index == 0) {
>

  reply	other threads:[~2015-06-06  9:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 13:09 [U-Boot] [PATCH] image-fit: Fix compiler warning in fit_conf_print() Hans de Goede
2015-06-06  9:33 ` Hans de Goede [this message]
2015-06-06 13:30 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5572BE79.4060200@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox