From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Sunxi NAND support for U-Boot
Date: Sat, 06 Jun 2015 17:09:53 +0200 [thread overview]
Message-ID: <55730D41.3090807@redhat.com> (raw)
In-Reply-To: <1433505164-24112-1-git-send-email-r.spliet@ultimaker.com>
Hi Roy,
Thanks for your work on this!
On 05-06-15 13:52, Roy Spliet wrote:
> Following up on earlier SPL patches, here a series based on Yassin Jaffer's
> work to bring NAND support to U-boot. RFC because I know that the sunxi nand
> configuration options are dependent on a work-in-progress by Daniel - trying
> to deliver a single SPL for both MMC and NAND boot.
I've just tested Daniel's patches on a board with an eMMC, fixed 2 small bugs
related to eMMC handling and merged them into u-boot-sunxi/next.
So it would probably be best to base your next version of the patches on
top of u-boot-sunxi/next which other then having Daniel's patches is
following u-boot/master atm.
> Given I have spent the past few weeks learning how Boris' original driver
> works, I have probably grown a bit blind for potentially existing issues.
> Please provide plenty of feedback so I can bring this in good shape.
>
> Patches tested on an Olimex Lime with 4GB Hynix nand. Has a partition as
> defined in sunxi-common.h with two UBIFS partitions (boot, rootfs) set up in
> Linux. To me it feels self-explanatory how to set this up, but I've spent the
> last few weeks full-time on this, implying my view of the world and how it
> revolves around MTD is rather distorted. Feel free to ask directed questions
> if you desire assistance in setting up and/or testing.
From the sunxi side these patches look good, I've one quite minor nitpick which
I will explain in a reply to the patch in question. I think the most work here
is getting the generic mtd patches ready and accepted by Scott Wood (the u-boot
mtd maintainer), so please coordinate this further with him.
Once those bits are in I'm more then happy to merge the sunxi side of things.
As for merging the mtd bits, since the u-boot mtd code is somewhat of a copy
of the Linux mtd code it may be best to simply sync the existing mtd code
up with the upstream kernel mtd code, and work on getting the missing mtd
bits merged into the upstream kernel first, and then merge the changes
back into the u-boot mtd code, that assumes that the u-boot mtd code still
is somewhat in sync with the kernel code atm though, and from your comments
I'm getting the impression that it is not...
Anyways I will leave figuring this out between you and Scott. Note that we
could use some help with upstreaming the kernel bits regardless of this.
If you plan to work on this, please coordinate with Boris as Boris will
likely start working on the mtd kernel code again soonish.
Regards,
Hans
next prev parent reply other threads:[~2015-06-06 15:09 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 11:52 [U-Boot] [RFC] Sunxi NAND support for U-Boot Roy Spliet
2015-06-05 11:52 ` [U-Boot] [RFC 01/11] mtd/nand: define struct nand_timings Roy Spliet
2015-06-05 11:52 ` [U-Boot] [RFC 02/11] mtd/nand: add ONFI timing mode to nand_timings converter Roy Spliet
2015-06-05 22:02 ` Scott Wood
2015-06-08 8:11 ` Roy Spliet
2015-06-08 8:34 ` [U-Boot] [linux-sunxi] " Michal Suchanek
2015-06-08 8:41 ` Roy Spliet
2015-06-14 11:59 ` Boris Brezillon
2015-06-08 20:24 ` [U-Boot] " Scott Wood
2015-06-10 8:33 ` Hans de Goede
2015-06-10 19:06 ` Scott Wood
2015-06-05 11:52 ` [U-Boot] [RFC 03/11] mtd/nand: support ONFI timing mode retrieval for non-ONFI Roy Spliet
2015-06-14 11:53 ` Boris Brezillon
2015-06-05 11:52 ` [U-Boot] [RFC 04/11] mtd/nand: add page status table (pst) Roy Spliet
2015-06-14 11:52 ` Boris Brezillon
2015-06-05 11:52 ` [U-Boot] [RFC 05/11] mtd/nand: take nand_ecc_ctrl initialization out of nand_scan_tail Roy Spliet
2015-06-14 11:50 ` Boris Brezillon
2015-06-05 11:52 ` [U-Boot] [RFC 06/11] mtd/nand: Add randomisation layer Roy Spliet
2015-06-14 11:47 ` Boris Brezillon
2015-06-05 11:52 ` [U-Boot] [RFC 07/11] mtd/nand Add Sunxi NAND driver Roy Spliet
2015-06-14 11:42 ` Boris Brezillon
2015-06-14 11:45 ` Boris Brezillon
2015-06-05 11:52 ` [U-Boot] [RFC 08/11] mtd/nand: Add DT definitions for Olimex Lime Roy Spliet
2015-06-14 11:39 ` Boris Brezillon
2015-06-05 11:52 ` [U-Boot] [RFC 09/11] sunxi/nand: Enable UBI and NAND commands Roy Spliet
2015-06-06 15:13 ` Hans de Goede
2015-06-06 15:36 ` Ian Campbell
2015-06-08 7:38 ` Roy Spliet
2015-06-08 9:12 ` Ian Campbell
2015-06-05 11:52 ` [U-Boot] [RFC 10/11] mtd/nand: Define bootcmd for nand Roy Spliet
2015-06-05 11:52 ` [U-Boot] [RFC 11/11] mtd/nand: Sunxi NAND boot partition definitions Roy Spliet
2015-06-07 16:48 ` [U-Boot] [linux-sunxi] " Michal Suchanek
2015-06-08 8:38 ` Roy Spliet
2015-06-08 8:54 ` Michal Suchanek
2015-06-08 9:11 ` Roy Spliet
2015-06-08 10:48 ` Yassin
2015-06-08 11:35 ` Roy Spliet
2015-06-14 11:31 ` Boris Brezillon
2015-06-15 8:00 ` Hans de Goede
2015-06-08 13:16 ` Hans de Goede
2015-06-08 13:56 ` Roy Spliet
2015-06-14 11:25 ` Boris Brezillon
2015-06-14 11:56 ` Michal Suchanek
2015-06-14 12:18 ` Boris Brezillon
2015-06-14 17:42 ` Michal Suchanek
2015-06-14 19:07 ` Boris Brezillon
2015-06-06 15:09 ` Hans de Goede [this message]
2015-06-06 15:11 ` [U-Boot] [RFC] Sunxi NAND support for U-Boot Hans de Goede
2015-06-14 11:13 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55730D41.3090807@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox