From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roy Spliet Date: Mon, 08 Jun 2015 09:38:33 +0200 Subject: [U-Boot] [RFC 09/11] sunxi/nand: Enable UBI and NAND commands In-Reply-To: <1433604973.3342.20.camel@hellion.org.uk> References: <1433505164-24112-1-git-send-email-r.spliet@ultimaker.com> <1433505164-24112-10-git-send-email-r.spliet@ultimaker.com> <55730E29.8040807@redhat.com> <1433604973.3342.20.camel@hellion.org.uk> Message-ID: <55754679.4050403@ultimaker.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Oh yes, thanks for pointing this one out. I increased the malloc pool during debugging as google hinted towards UBI being rather memory-hungry, but forgot to double-check whether it was required. I just did, and as it turns out it really only needs to be increased to 8MiB for UBI to work in my set-up. As we have plenty of memory anyway, should I allocate some extra headroom for set-ups I haven't tested (e.g. many partitions, large bad-block tables etc.) and go for 16MiB instead? Roy Op 06-06-15 om 17:36 schreef Ian Campbell: > On Sat, 2015-06-06 at 17:13 +0200, Hans de Goede wrote: >>> @@ -113,7 +113,7 @@ >>> #endif >>> >>> /* 4MB of malloc() pool */ >>> -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (4 << 20)) >>> +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (64 << 20)) >>> >>> /* >>> * Miscellaneous configurable options >> Please update the comment about malloc_pool size to match :) > ...and explain in the commit log why this needs increasing as part of > this change. > > Ian. > -- IMAGINE IT >> MAKE IT Meet us online at Twitter , Facebook , Google+ www.ultimaker.com