* [U-Boot] [PATCH v2] Bananapi: Fix ethernet device initialization
@ 2015-06-07 13:25 Maxin B. John
2015-06-08 13:23 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Maxin B. John @ 2015-06-07 13:25 UTC (permalink / raw)
To: u-boot
Ethernet device initialization fails with the following message:
Net: PH: dir_output: error: gpio PH23 not reserved
Phy 1 not found
PHY reset timed out
eth0: ethernet at 01c50000
Tested on Banana Pi board.
Signed-off-by: Maxin B. John <maxin.john@enea.com>
---
arch/arm/cpu/armv7/sunxi/board.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c
index a82c8b9..4b2494e 100644
--- a/arch/arm/cpu/armv7/sunxi/board.c
+++ b/arch/arm/cpu/armv7/sunxi/board.c
@@ -223,6 +223,7 @@ int cpu_eth_init(bd_t *bis)
__maybe_unused int rc;
#ifdef CONFIG_MACPWR
+ gpio_request(CONFIG_MACPWR, "macpwr");
gpio_direction_output(CONFIG_MACPWR, 1);
mdelay(200);
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v2] Bananapi: Fix ethernet device initialization
2015-06-07 13:25 [U-Boot] [PATCH v2] Bananapi: Fix ethernet device initialization Maxin B. John
@ 2015-06-08 13:23 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2015-06-08 13:23 UTC (permalink / raw)
To: u-boot
Hi Maxin,
On 07-06-15 15:25, Maxin B. John wrote:
> Ethernet device initialization fails with the following message:
> Net: PH: dir_output: error: gpio PH23 not reserved
> Phy 1 not found
> PHY reset timed out
> eth0: ethernet at 01c50000
>
> Tested on Banana Pi board.
>
> Signed-off-by: Maxin B. John <maxin.john@enea.com>
Thanks, I actually wrote exactly the same patch myself yesterday, and that
just got acked by Ian today. I'll make sure to get the fix upstream
soonish.
Regards,
Hans
> ---
> arch/arm/cpu/armv7/sunxi/board.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/cpu/armv7/sunxi/board.c b/arch/arm/cpu/armv7/sunxi/board.c
> index a82c8b9..4b2494e 100644
> --- a/arch/arm/cpu/armv7/sunxi/board.c
> +++ b/arch/arm/cpu/armv7/sunxi/board.c
> @@ -223,6 +223,7 @@ int cpu_eth_init(bd_t *bis)
> __maybe_unused int rc;
>
> #ifdef CONFIG_MACPWR
> + gpio_request(CONFIG_MACPWR, "macpwr");
> gpio_direction_output(CONFIG_MACPWR, 1);
> mdelay(200);
> #endif
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-08 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-07 13:25 [U-Boot] [PATCH v2] Bananapi: Fix ethernet device initialization Maxin B. John
2015-06-08 13:23 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox