From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Fri, 12 Jun 2015 09:35:37 +0200 Subject: [U-Boot] [PATCH] sunxi: Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default In-Reply-To: References: <1433355136-13627-1-git-send-email-hdegoede@redhat.com> <20150603221210.GV1728@bill-the-cat> <20150611151258.GT1728@bill-the-cat> Message-ID: <557A8BC9.3020706@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 11-06-15 18:12, Joe Hershberger wrote: > Hi Tom, > > On Thu, Jun 11, 2015 at 10:12 AM, Tom Rini wrote: >> On Thu, Jun 11, 2015 at 09:14:33AM -0500, Joe Hershberger wrote: >>> Hi Tom, >>> >>> On Wed, Jun 3, 2015 at 5:12 PM, Tom Rini wrote: >>>> On Wed, Jun 03, 2015 at 08:12:16PM +0200, Hans de Goede wrote: >>>> >>>>> Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default rather then >>>>> needing to have this in every sunxi defconfig file. >>>>> >>>>> This also fixes the Merrii_A80_Optimus defconfig no longer building. >>>>> >>>>> Cc: Maxin B. John >>>>> Reported-by: Maxin B. John >>>>> Signed-off-by: Hans de Goede >>>> >>>> Joe? Masahiro? It feels like something has gone wrong with the >>>> conversion here. Or do people need to get used to the defconfig files >>>> being a non-trivial size? Or do we need some more default y if ... >>>> lines around things? Or a few of the above? Thanks! >>> >>> I'm surprised you pulled this in for -rc2. I guess we can always revert it. >> >> OK, so where did we end up again exactly? Ah yes, (a) we can't >> unexpectedly break peoples build. So I took this for now. > > This isn't fixing a breakage... It does fix breakage as stated i the commit message the Merrii_A80_Optimus target was broken by your patch, likely because your patch was generated against a tree which did not have that one yet. > it simply reduced the size of the sunxi boards' defconfig That is because I choose a solution were I do not need to fix this over and over again and one were something which comes pretty close to pure noise was poluting all the sunxi defconfigs. > and caused defconfig noise in every other > board when running savedefconfig. I did not realize that, sorry about that. Regards, Hans