From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] common: cmd_part: Error prints on failures
Date: Mon, 15 Jun 2015 09:00:58 -0600 [thread overview]
Message-ID: <557EE8AA.9030903@wwwdotorg.org> (raw)
In-Reply-To: <1434184697-23410-4-git-send-email-contact@paulk.fr>
On 06/13/2015 02:38 AM, Paul Kocialkowski wrote:
> When a failure occurs when selecting the device or partition, the user should be
> notified through an error print.
> diff --git a/common/cmd_part.c b/common/cmd_part.c
> @@ -38,8 +38,10 @@ static int do_part_uuid(int argc, char * const argv[])
> return CMD_RET_USAGE;
>
> part = get_device_and_partition(argv[0], argv[1], &dev_desc, &info, 0);
> - if (part < 0)
> + if (part < 0) {
> + error("Invalid device and/or partition\n");
A very quick look at the implementation of get_device_and_partition()
(and all the other relevant functions for this patch) implies the
implementation already prints an error message. If you found a case
where that isn't true, I think those functions should be fixed, not all
their callers.
next prev parent reply other threads:[~2015-06-15 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 8:38 [U-Boot] [PATCH v2 0/3] common: cmd_part: start and size sub-commands introduction Paul Kocialkowski
2015-06-13 8:38 ` [U-Boot] [PATCH v2 1/3] common: cmd_part: Proper alignment Paul Kocialkowski
2015-06-13 8:38 ` [U-Boot] [PATCH v2 2/3] common: cmd_part: start and size sub-commands introduction Paul Kocialkowski
2015-06-15 14:59 ` Stephen Warren
2015-06-15 16:02 ` Tom Rini
2015-06-15 19:36 ` Paul Kocialkowski
2015-06-15 16:13 ` Paul Kocialkowski
2015-06-13 8:38 ` [U-Boot] [PATCH v2 3/3] common: cmd_part: Error prints on failures Paul Kocialkowski
2015-06-15 15:00 ` Stephen Warren [this message]
2015-06-15 19:25 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557EE8AA.9030903@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox