From: Vitaly Andrianov <vitalya@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] keystone2: use SPD info to configure K2HK and K2E DDR3
Date: Mon, 15 Jun 2015 12:13:26 -0400 [thread overview]
Message-ID: <557EF9A6.3010409@ti.com> (raw)
In-Reply-To: <20150615134744.GO1728@bill-the-cat>
On 06/15/2015 09:47 AM, Tom Rini wrote:
> On Mon, Jun 15, 2015 at 08:32:21AM -0400, Vitaly Andrianov wrote:
>
>> This commit replaces hard-coded EMIF and PHY DDR3 configurations for
>> predefined SODIMMs to a calculated configuration. The SODIMM parameters
>> are read from SODIMM's SPD and used to calculated the configuration.
>>
>> The current commit supports calculation for DDR3 with 1600MHz and 1333MHz
>> only.
>>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>
> There's two problems here. The first is, no floating point math in
> U-Boot. The second is that between board/ti/ks2_evm/ddr3_spd.c that
> you're adding and drivers/ddr/fsl/ddr3_dimm_params.c and
> drivers/ddr/mvebu/ddr3_spd.c it seems like we have two and you would add
> a 3rd file for reading the standard-defined SPD data. We need one set
> of functions in drivers/ddr/ to read the spd information and do whatever
> really common bits can be done with it and the rest in
> drivers/ddr/subdir/.
>
Tom,
Thank you. I'll rework the calculation not to use floating point math.
Also I'll check whether I can reuse existing drivers.
Regards,
Vitaly
prev parent reply other threads:[~2015-06-15 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:32 [U-Boot] [PATCH] keystone2: use SPD info to configure K2HK and K2E DDR3 Vitaly Andrianov
2015-06-15 13:47 ` Tom Rini
2015-06-15 16:13 ` Vitaly Andrianov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557EF9A6.3010409@ti.com \
--to=vitalya@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox