From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Andrianov Date: Mon, 15 Jun 2015 12:13:26 -0400 Subject: [U-Boot] [PATCH] keystone2: use SPD info to configure K2HK and K2E DDR3 In-Reply-To: <20150615134744.GO1728@bill-the-cat> References: <1434371541-32633-1-git-send-email-vitalya@ti.com> <20150615134744.GO1728@bill-the-cat> Message-ID: <557EF9A6.3010409@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/15/2015 09:47 AM, Tom Rini wrote: > On Mon, Jun 15, 2015 at 08:32:21AM -0400, Vitaly Andrianov wrote: > >> This commit replaces hard-coded EMIF and PHY DDR3 configurations for >> predefined SODIMMs to a calculated configuration. The SODIMM parameters >> are read from SODIMM's SPD and used to calculated the configuration. >> >> The current commit supports calculation for DDR3 with 1600MHz and 1333MHz >> only. >> >> Signed-off-by: Vitaly Andrianov > > There's two problems here. The first is, no floating point math in > U-Boot. The second is that between board/ti/ks2_evm/ddr3_spd.c that > you're adding and drivers/ddr/fsl/ddr3_dimm_params.c and > drivers/ddr/mvebu/ddr3_spd.c it seems like we have two and you would add > a 3rd file for reading the standard-defined SPD data. We need one set > of functions in drivers/ddr/ to read the spd information and do whatever > really common bits can be done with it and the rest in > drivers/ddr/subdir/. > Tom, Thank you. I'll rework the calculation not to use floating point math. Also I'll check whether I can reuse existing drivers. Regards, Vitaly