From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Mon, 15 Jun 2015 11:18:01 -0600
Subject: [U-Boot] [PATCH 2/4] ARM: Tegra210: Add support to common Tegra
 source/config files
In-Reply-To: <1433363711-29554-3-git-send-email-twarren@nvidia.com>
References: <1433363711-29554-1-git-send-email-twarren@nvidia.com>
 <1433363711-29554-3-git-send-email-twarren@nvidia.com>
Message-ID: <557F08C9.5090409@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/03/2015 02:35 PM, Tom Warren wrote:
> Derived from Tegra124, modify as appropriate during T210
> board bringup. Cleaned up debug statements to conserve
> string space, too.
>
> Note that the 'empty' Kconfig for Tegra210 will cause
> an innocuous build warning, but it'll go away when a
> real T210 board is instantiated.

> diff --git a/arch/arm/mach-tegra/clock.c b/arch/arm/mach-tegra/clock.c
> index cdd5438..2ef8ae2 100644
> --- a/arch/arm/mach-tegra/clock.c
> +++ b/arch/arm/mach-tegra/clock.c
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 2010-2014, NVIDIA CORPORATION.  All rights reserved.
> + * Copyright (c) 2010-2015, NVIDIA CORPORATION.  All rights reserved.
>    *
>    * This program is free software; you can redistribute it and/or modify it
>    * under the terms and conditions of the GNU General Public License,
> @@ -629,6 +629,7 @@ static void set_avp_clock_source(u32 src)
>   /*
>    * This function is useful on Tegra30, and any later SoCs that have compatible
>    * PLLP configuration registers.
> + * NOTE: Not used on Tegra210 - see tegra210_setup_pllp in T210 clock.c

I think we're only meant to update the copyright date for non-trivial 
changes.

> diff --git a/arch/arm/mach-tegra/cpu.c b/arch/arm/mach-tegra/cpu.c

> @@ -39,6 +40,8 @@ int get_num_cpus(void)
>   		break;
>   	case CHIPID_TEGRA30:
>   	case CHIPID_TEGRA114:
> +	case CHIPID_TEGRA124:
> +	case CHIPID_TEGRA210:

It would be nice to break out the T124 change as a separate patch, since 
it affects something other than T210.

> diff --git a/arch/arm/mach-tegra/cpu.h b/arch/arm/mach-tegra/cpu.h

> -#define CORESIGHT_UNLOCK	0xC5ACCE55;
> +#define CORESIGHT_UNLOCK	0xC5ACCE55

Do we use that anywhere? If not, perhaps just delete it, probably as a 
separate patch.