public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Markus Niebel <list-09_u-boot@tqsc.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpio: mxc_gpio: enable DM gpio before relocation
Date: Wed, 17 Jun 2015 08:18:02 +0200	[thread overview]
Message-ID: <5581111A.8040506@tqsc.de> (raw)
In-Reply-To: <CAPnjgZ0qVZehn++NX9vO_5J4nFD_5jqGqGwT7_VpUc45cXjsxw@mail.gmail.com>

Hello Simon,

Am 16.06.2015 um 23:44 schrieb Simon Glass:
> Hi Markus,
> 
> On 16 June 2015 at 01:08, Markus Niebel <list-09_u-boot@tqsc.de> wrote:
>> From: Markus Niebel <Markus.Niebel@tq-group.com>
>>
>> gpio often are needed to detect revision and variants.
>> Therefore gpio should be available ASAP.
>>
>> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
>> ---
>>  drivers/gpio/mxc_gpio.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
>> index 2012f99..925758a 100644
>> --- a/drivers/gpio/mxc_gpio.c
>> +++ b/drivers/gpio/mxc_gpio.c
>> @@ -330,6 +330,7 @@ U_BOOT_DRIVER(gpio_mxc) = {
>>         .priv_auto_alloc_size = sizeof(struct mxc_bank_info),
>>         .of_match = mxc_gpio_ids,
>>         .bind   = mxc_gpio_bind,
>> +       .flags  = DM_FLAG_PRE_RELOC,
>>  };
>>
>>  #ifndef CONFIG_OF_CONTROL
>> --
>> 2.3.0
>>
> 
> This should really be done in the device tree with the
> u-boot,dm-pre-reloc property for the particular GPIO banks you need. I
> don't think this should be a global setting.
> 

I totally agree for the longer run - but tegra gpio does it the same way.

Regards,
Markus

  reply	other threads:[~2015-06-17  6:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16  7:08 [U-Boot] [PATCH] gpio: mxc_gpio: enable DM gpio before relocation Markus Niebel
2015-06-16 21:44 ` Simon Glass
2015-06-17  6:18   ` Markus Niebel [this message]
2015-06-17 15:04     ` Simon Glass
2015-06-17 17:12       ` Markus Niebel
2015-06-17 17:17         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5581111A.8040506@tqsc.de \
    --to=list-09_u-boot@tqsc.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox