public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling
Date: Wed, 17 Jun 2015 15:39:57 +0200	[thread overview]
Message-ID: <558178AD.8070408@redhat.com> (raw)
In-Reply-To: <1434396106.2324.53.camel@collins>

Hi,

On 15-06-15 21:21, Paul Kocialkowski wrote:
> Le dimanche 14 juin 2015 ? 12:40 +0200, Hans de Goede a ?crit :
>> Hi Ian, Paul,
>>
>> Here is a patch to fix the problems where most usb devices will no longer
>> work after a "usb reset ", when connected to the otg controller in host
>> mode + a related cleanup patch.
>
> This works fine for an USB storage device and an USB2 keyboard but does
> not work with an USB1 keyboard, with error:
>
> sunxi# usb reset
> resetting USB...
> USB0:   scanning bus 0 for devices... USB device descriptor short read
> (expected 8, got 0)
> No USB Device found

Hmm, did you test my sunxi-wip branch perhaps? This bug does exist there,
but it is the result of me refactoring things so that the musb code can
use the device-model when build in host mode, which will allow enabling
both the otg port in host mode and regular usb hosts in a single build,
which is esp. useful for boards which have the otg hooked up in host-only
mode (e.g. connected to an usb-a receptacle, or usb <-> sata bridge).

I've just retested current u-boot/master with just this patch and the
problem you are describing does not happen then.

Sorry about my sunxi-wip being broken atm I try to always keep it 100%
functional, but well it is a wip tree after all.

Regards,

Hans

  reply	other threads:[~2015-06-17 13:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14 10:40 [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling Hans de Goede
2015-06-14 10:40 ` [U-Boot] [PATCH 1/2] sunxi: musb: Do not fully reset the controler from sunxi_musb_disable Hans de Goede
2015-06-14 11:46   ` Ian Campbell
2015-06-14 17:21     ` Hans de Goede
2015-06-14 10:40 ` [U-Boot] [PATCH 2/2] sunxi: musb: Remove unused sunxi_musb_exit method Hans de Goede
2015-06-14 11:47   ` Ian Campbell
2015-06-15 19:21 ` [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling Paul Kocialkowski
2015-06-17 13:39   ` Hans de Goede [this message]
2015-06-19  9:11     ` Paul Kocialkowski
2015-06-19 12:35 ` Marek Vasut
2015-06-19 13:07   ` Hans de Goede
2015-06-19 13:08     ` Marek Vasut
2015-06-26 10:20 ` Maxime Ripard
2015-06-26 11:01   ` Hans de Goede
2015-06-28 20:42     ` Maxime Ripard
2015-06-26 11:02   ` Hans de Goede
2015-06-26 11:11     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558178AD.8070408@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox