From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 19/22] sunxi: musb: Move musb config and platdata to the sunxi-musb glue
Date: Fri, 19 Jun 2015 11:35:22 +0200 [thread overview]
Message-ID: <5583E25A.1090408@redhat.com> (raw)
In-Reply-To: <1434699821.3342.125.camel@hellion.org.uk>
Hi,
On 19-06-15 09:43, Ian Campbell wrote:
> On Wed, 2015-06-17 at 21:34 +0200, Hans de Goede wrote:
>> Move the musb config and platdata to the sunxi-musb glue, which is where
>> it really belongs. This is preparation patch for adding device-model
>> support for the sunxi-musb-host code.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> arch/arm/include/asm/arch-sunxi/usb_phy.h | 7 +++++++
>> board/sunxi/board.c | 28 ++-----------------------
>> drivers/usb/musb-new/sunxi.c | 35 ++++++++++++++++++++++---------
>> 3 files changed, 34 insertions(+), 36 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-sunxi/usb_phy.h b/arch/arm/include/asm/arch-sunxi/usb_phy.h
>> index 5a9cacb..17d31b8 100644
>> --- a/arch/arm/include/asm/arch-sunxi/usb_phy.h
>> +++ b/arch/arm/include/asm/arch-sunxi/usb_phy.h
>> @@ -19,3 +19,10 @@ void sunxi_usb_phy_power_off(int index);
>> int sunxi_usb_phy_vbus_detect(int index);
>> int sunxi_usb_phy_id_detect(int index);
>> void sunxi_usb_phy_enable_squelch_detect(int index, int enable);
>> +
>> +/* Not really phy related, but we have to declare this somewhere ... */
>
> I guess arch/arm/include/asm/arch-sunxi/usbc.h isn't any better?
Well we do not have that, and I did not feel it was worth adding yet
another .h file for just this one function.
>
> With it here or there:
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>
Regards,
Hans
>
>> +#if defined(CONFIG_MUSB_HOST) || defined(CONFIG_MUSB_GADGET)
>> +void sunxi_musb_board_init(void);
>> +#else
>> +#define sunxi_musb_board_init()
>> +#endif
>
> Ian.
>
next prev parent reply other threads:[~2015-06-19 9:35 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 19:33 [U-Boot] [PATCH 00/22] Convert musb host mode code to the device-model Hans de Goede
2015-06-17 19:33 ` [U-Boot] [PATCH 01/22] usb: Always declare usb function prototypes Hans de Goede
2015-06-29 3:44 ` Simon Glass
2015-07-07 18:33 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 02/22] usb: Drop device-model specific copy of usb_legacy_port_reset Hans de Goede
2015-06-29 3:44 ` Simon Glass
2015-07-07 18:33 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 03/22] usb: usb_setup_device: Drop unneeded portnr function argument Hans de Goede
2015-06-29 3:44 ` Simon Glass
2015-06-30 12:29 ` Hans de Goede
2015-06-30 14:51 ` Simon Glass
2015-07-07 18:34 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 04/22] usb: Pass device instead of portnr to usb_legacy_port_reset Hans de Goede
2015-06-29 3:44 ` Simon Glass
2015-06-30 12:31 ` Hans de Goede
2015-06-30 14:58 ` Simon Glass
2015-07-07 18:34 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 05/22] usb: Add an usb_device parameter to usb_reset_root_port Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:34 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 06/22] dm: Export device_chld_remove / device_chld_unbind Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-06-30 12:33 ` Hans de Goede
2015-06-17 19:33 ` [U-Boot] [PATCH 07/22] dm: usb: Fix "usb tree" output Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:34 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 08/22] dm: usb: Use device_chld_remove and _unbind to clean up usb devs on stop Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-06-30 12:54 ` Hans de Goede
2015-06-30 14:58 ` Simon Glass
2015-06-30 15:54 ` Hans de Goede
2015-06-30 16:07 ` Simon Glass
2015-06-30 20:20 ` Hans de Goede
2015-06-30 21:20 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 09/22] dm: usb: Allow usb host drivers to implement usb_reset_root_port Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:35 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 10/22] dm: usb: Do not assume that first child is always a hub Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:35 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 11/22] musb: Allow musb_platform_enable to return an error code Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:35 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 12/22] musb: Update usb-compat to work with struct usb_device without a parent ptr Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-01 14:57 ` Hans de Goede
2015-07-07 18:35 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 13/22] musb: Rename and wrap public functions Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:35 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 14/22] musb: Add musb_host_data struct to hold global data Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:36 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 15/22] musb: Add device-model support to the musb-host u-boot glue Hans de Goede
2015-06-29 3:45 ` Simon Glass
2015-07-07 18:36 ` Simon Glass
2015-06-17 19:33 ` [U-Boot] [PATCH 16/22] sunxi: usb-phy: Add support for reading otg id pin value Hans de Goede
2015-06-19 7:37 ` Ian Campbell
2015-06-17 19:34 ` [U-Boot] [PATCH 17/22] sunxi: musb: Move vbus check to sunxi_musb_enable Hans de Goede
2015-06-19 7:37 ` Ian Campbell
2015-06-17 19:34 ` [U-Boot] [PATCH 18/22] sunxi: musb: Add id pin support Hans de Goede
2015-06-19 7:40 ` Ian Campbell
2015-06-19 9:33 ` Hans de Goede
2015-06-17 19:34 ` [U-Boot] [PATCH 19/22] sunxi: musb: Move musb config and platdata to the sunxi-musb glue Hans de Goede
2015-06-19 7:43 ` Ian Campbell
2015-06-19 9:35 ` Hans de Goede [this message]
2015-06-19 13:31 ` Ian Campbell
2015-06-17 19:34 ` [U-Boot] [PATCH 20/22] sunxi: musb: Use device-model for musb host mode Hans de Goede
2015-06-19 7:45 ` Ian Campbell
2015-06-17 19:34 ` [U-Boot] [PATCH 21/22] sunxi: Kconfig: Enable CONFIG_USB and friends by default on sunxi Hans de Goede
2015-06-19 7:46 ` Ian Campbell
2015-06-19 9:37 ` Hans de Goede
2015-06-19 13:32 ` Ian Campbell
2015-06-17 19:34 ` [U-Boot] [PATCH 22/22] sunxi: ga10h: Enable both otg and regular usb host controllers Hans de Goede
2015-06-19 7:46 ` Ian Campbell
2015-06-19 13:10 ` [U-Boot] [PATCH 00/22] Convert musb host mode code to the device-model Simon Glass
2015-06-19 13:12 ` Hans de Goede
2015-06-19 13:14 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5583E25A.1090408@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox