From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Fri, 19 Jun 2015 11:35:22 +0200 Subject: [U-Boot] [PATCH 19/22] sunxi: musb: Move musb config and platdata to the sunxi-musb glue In-Reply-To: <1434699821.3342.125.camel@hellion.org.uk> References: <1434569645-30322-1-git-send-email-hdegoede@redhat.com> <1434569645-30322-20-git-send-email-hdegoede@redhat.com> <1434699821.3342.125.camel@hellion.org.uk> Message-ID: <5583E25A.1090408@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 19-06-15 09:43, Ian Campbell wrote: > On Wed, 2015-06-17 at 21:34 +0200, Hans de Goede wrote: >> Move the musb config and platdata to the sunxi-musb glue, which is where >> it really belongs. This is preparation patch for adding device-model >> support for the sunxi-musb-host code. >> >> Signed-off-by: Hans de Goede >> --- >> arch/arm/include/asm/arch-sunxi/usb_phy.h | 7 +++++++ >> board/sunxi/board.c | 28 ++----------------------- >> drivers/usb/musb-new/sunxi.c | 35 ++++++++++++++++++++++--------- >> 3 files changed, 34 insertions(+), 36 deletions(-) >> >> diff --git a/arch/arm/include/asm/arch-sunxi/usb_phy.h b/arch/arm/include/asm/arch-sunxi/usb_phy.h >> index 5a9cacb..17d31b8 100644 >> --- a/arch/arm/include/asm/arch-sunxi/usb_phy.h >> +++ b/arch/arm/include/asm/arch-sunxi/usb_phy.h >> @@ -19,3 +19,10 @@ void sunxi_usb_phy_power_off(int index); >> int sunxi_usb_phy_vbus_detect(int index); >> int sunxi_usb_phy_id_detect(int index); >> void sunxi_usb_phy_enable_squelch_detect(int index, int enable); >> + >> +/* Not really phy related, but we have to declare this somewhere ... */ > > I guess arch/arm/include/asm/arch-sunxi/usbc.h isn't any better? Well we do not have that, and I did not feel it was worth adding yet another .h file for just this one function. > > With it here or there: > > Acked-by: Ian Campbell Regards, Hans > >> +#if defined(CONFIG_MUSB_HOST) || defined(CONFIG_MUSB_GADGET) >> +void sunxi_musb_board_init(void); >> +#else >> +#define sunxi_musb_board_init() >> +#endif > > Ian. >