public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] sunxi: musb: Improve output during probing
Date: Tue, 23 Jun 2015 12:02:49 +0200	[thread overview]
Message-ID: <55892EC9.7010906@redhat.com> (raw)
In-Reply-To: <1434989477.28264.176.camel@hellion.org.uk>

Hi,

On 22-06-15 18:11, Ian Campbell wrote:
> On Mon, 2015-06-22 at 17:39 +0200, Hans de Goede wrote:
>> How about the following:
>>
>>
>> Subject: [PATCH 1/3] sunxi: musb: Improve output during probing
>>
>> When we return an error the usb core will log a message, so in this case
>> do not print anything.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Much better, especially given the below.
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks.

>
>>
>> --- a/drivers/usb/musb-new/sunxi.c
>> +++ b/drivers/usb/musb-new/sunxi.c
>> @@ -301,21 +301,22 @@ int musb_usb_probe(struct udevice *dev)
>>    {
>>           struct musb_host_data *host = dev_get_priv(dev);
>>           struct usb_bus_priv *priv = dev_get_uclass_priv(dev);
>> +       int ret;
>
> Wrong sort of w/space I suspect.

Nope, this comes from me copy and pasting the diff output
from a xterm, I just double checked and the whitespace is as
it should be in my tree :)

Regards,

Hans

  reply	other threads:[~2015-06-23 10:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-20 15:35 [U-Boot] [PATCH 0/3] sunxi: Enable both ehci and otg in host mode on various boards Hans de Goede
2015-06-20 15:35 ` [U-Boot] [PATCH 1/3] sunxi: musb: Improve output during probing Hans de Goede
2015-06-21  8:00   ` Ian Campbell
2015-06-22 15:39     ` Hans de Goede
2015-06-22 16:11       ` Ian Campbell
2015-06-23 10:02         ` Hans de Goede [this message]
2015-06-20 15:35 ` [U-Boot] [PATCH 2/3] sunxi: musb: Stop treating not having a vbus-det gpio as an error Hans de Goede
2015-06-21  8:00   ` Ian Campbell
2015-06-20 15:35 ` [U-Boot] [PATCH 3/3] sunxi: Enable both ehci and otg in host mode on various boards Hans de Goede
2015-06-21  8:01   ` Ian Campbell
2015-06-22 15:40     ` Hans de Goede
2015-06-20 16:08 ` [U-Boot] [PATCH 0/3] " Marek Vasut
2015-06-20 18:12   ` Hans de Goede
2015-06-20 18:26     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55892EC9.7010906@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox