From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Tue, 23 Jun 2015 12:02:49 +0200 Subject: [U-Boot] [PATCH 1/3] sunxi: musb: Improve output during probing In-Reply-To: <1434989477.28264.176.camel@hellion.org.uk> References: <1434814509-21484-1-git-send-email-hdegoede@redhat.com> <1434814509-21484-2-git-send-email-hdegoede@redhat.com> <1434873606.17598.2.camel@hellion.org.uk> <55882C3B.9010709@redhat.com> <1434989477.28264.176.camel@hellion.org.uk> Message-ID: <55892EC9.7010906@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 22-06-15 18:11, Ian Campbell wrote: > On Mon, 2015-06-22 at 17:39 +0200, Hans de Goede wrote: >> How about the following: >> >> >> Subject: [PATCH 1/3] sunxi: musb: Improve output during probing >> >> When we return an error the usb core will log a message, so in this case >> do not print anything. >> >> Signed-off-by: Hans de Goede > > Much better, especially given the below. > > Acked-by: Ian Campbell Thanks. > >> >> --- a/drivers/usb/musb-new/sunxi.c >> +++ b/drivers/usb/musb-new/sunxi.c >> @@ -301,21 +301,22 @@ int musb_usb_probe(struct udevice *dev) >> { >> struct musb_host_data *host = dev_get_priv(dev); >> struct usb_bus_priv *priv = dev_get_uclass_priv(dev); >> + int ret; > > Wrong sort of w/space I suspect. Nope, this comes from me copy and pasting the diff output from a xterm, I just double checked and the whitespace is as it should be in my tree :) Regards, Hans