[U-Boot] Marvell Armada XP SATA support

Anton Schubert
2015-07-01T15:09:03Z

Hi Stefan,

2015-07-01 16:55 GMT+02:00 Stefan Roese <sr@denx.de>:

> Hi Anton,
>
> On 01.07.2015 15:41, Anton Schubert wrote:
>
>> 2015-07-01 12:39 GMT+02:00 Stefan Roese <sr at denx.de <mailto:sr@denx.de>>:
>>
>> Hi Anton,
>>
>> On 01.07.2015 12:20, Anton Schubert wrote:
>>
>> I figured out my problem was just ATA security. After unlocking
>> the code
>> above works fine for MV78260.
>>
>>
>> Great. Then please send a patch to the list to add support for SATA
>> on AXP.
>>
>> Thanks,
>> Stefan
>>
>>
>> Should i move the mbus init code to mach-mvebu/cpu.c for that purpose?
>>
>
> No, please keep it in the driver. I only moved it into cpu.c since there
> is no MVEBU specific driver in the AHCI/SATA case.
>
> Additionally, what would you recommend for the MVEBU_SATA_BASE define as
>> it would be ambiguous after the a38x patch.
>>
>
> Why not just use the same name/macro?
>

I think it would be a bit confusing with MVEBU_SATA0_BASE for A38X and
MVEBU_SATA_BASE for AXP in the same header. (As I don't have access to the
A38X Spec I don't know how similar they really are)

Anton