From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sat, 27 Jun 2015 18:17:38 +0200 Subject: [U-Boot] [PATCH v2 1/8] imx: mx6 correct is_soc_rev usage In-Reply-To: <1434018642-16990-1-git-send-email-Peng.Fan@freescale.com> References: <1434018642-16990-1-git-send-email-Peng.Fan@freescale.com> Message-ID: <558ECCA2.6020108@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peng, On 11/06/2015 12:30, Peng Fan wrote: > is_soc_rev should return a bool value, so use "==", but not "-", > change (is_soc_rev(CHIP_REV_1_0) > 0) to (soc_rev() > CHIP_REV_1_0). > This patch also add space between "&" for cpu_type(rev) macro. > > Signed-off-by: Peng Fan > --- > Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================