public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Please pull u-boot-sunxi master (fixes for v2015.07)
Date: Sun, 28 Jun 2015 17:39:28 +0200	[thread overview]
Message-ID: <55901530.1000900@redhat.com> (raw)
In-Reply-To: <20150626210528.GR28577@bill-the-cat>

Hi,

On 26-06-15 23:05, Tom Rini wrote:
> On Fri, Jun 26, 2015 at 12:13:51PM +0200, Hans de Goede wrote:
>
>> Hi Tom,
>>
>> Please pull u-boot-sunxi/master into master for two bug-fixes,
>> and one new board:
>>
>> The following changes since commit 325849ff3d4adeebb8f8f9bc5db950724df9bc21:
>>
>>    Merge git://git.denx.de/u-boot-usb (2015-06-19 16:46:51 -0400)
>>
>> are available in the git repository at:
>>
>>    http://git.denx.de/u-boot-sunxi.git master
>>
>> for you to fetch changes up to cbf389d94bf300a38d0a26f5aab2efbc9d76a56c:
>>
>>    sunxi: Add Sinlinx SinA33 defconfig (2015-06-26 11:56:33 +0200)
>>
>
> NAK, this needs a rework now, sorry!  Joe's changes mean the new
> defconfig needs updating.

Ugh, I'm somewhat surprised with these changes, both with the
contents of the changes, as with changes like these landing so
late in the cycle, esp. since these are not uncontroversial.

I've the feeling that these were merged without proper discussion
which is not good, and is esp. bad when it is done so late in the
cycle.

In essense these changes revert my earlier commit where I explictly added:

config CMD_SETEXPR
	default y

config CMD_NET
	default y

And not only does the just merged series revert these changes, to make
things worse it adds a whole lot more crap to the sunxi defconfigs.

Excuse my language but I've no other words for this, something which
we want enabled on every single sunxi board does not belong in the
defconfigs, we now have defconfig files where more of the lines are
this crap / noise, rather then actual board config, we really need
a better solution for providing per SoC defaults then just having them
all in the defconfig, having them all in the defconfig is crazy, esp.
as more and more compile time config gets moved into Kconfig.

So once more I find both the contents and the time of merging of
this patch-set ill advised, and I'm NOT happy with these changes.

Regards,

Hans

  reply	other threads:[~2015-06-28 15:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 10:13 [U-Boot] Please pull u-boot-sunxi master (fixes for v2015.07) Hans de Goede
2015-06-26 21:05 ` Tom Rini
2015-06-28 15:39   ` Hans de Goede [this message]
2015-06-28 16:06     ` Tom Rini
2015-06-30 13:11       ` Hans de Goede
2015-06-30 13:30         ` Ian Campbell
2015-06-30 13:34           ` Hans de Goede
2015-06-30 15:48           ` Joe Hershberger
2015-06-30 17:17             ` Tom Rini
2015-06-30 17:52         ` Tom Rini
2015-06-30 20:22           ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55901530.1000900@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox