public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] qe: transform parameter to compatible type
Date: Mon, 29 Jun 2015 11:27:19 -0700	[thread overview]
Message-ID: <55918E07.6010808@freescale.com> (raw)
In-Reply-To: <1430812413-7633-1-git-send-email-B45475@freescale.com>



On 05/05/2015 12:53 AM, Zhao Qiang wrote:
> when using printf, the parameter type need to be compatible
> type, so transform them to compatible type
> 
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
>  drivers/qe/qe.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c
> index 84e1433..f1df0a4 100644
> --- a/drivers/qe/qe.c
> +++ b/drivers/qe/qe.c
> @@ -313,9 +313,10 @@ static void qe_upload_microcode(const void *base,
>  
>  	if (ucode->major || ucode->minor || ucode->revision)
>  		printf("QE: uploading microcode '%s' version %u.%u.%u\n",
> -			ucode->id, ucode->major, ucode->minor, ucode->revision);
> +		       (char *)ucode->id, (u16)ucode->major, (u16)ucode->minor,
> +		       (u16)ucode->revision);
>  	else
> -		printf("QE: uploading microcode '%s'\n", ucode->id);
> +		printf("QE: uploading microcode '%s'\n", (char *)ucode->id);
>  

Would it be more appropriate to fix the structure in qe.h?
Is the size fixed for major and minor? They are declared as u8. I can't find
doc/README.qe_firmware as mentioned in the comment.

York

  parent reply	other threads:[~2015-06-29 18:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05  7:53 [U-Boot] [PATCH 1/2] qe: transform parameter to compatible type Zhao Qiang
2015-05-05  7:53 ` [U-Boot] [PATCH 2/2] qe: use strncpy instead of strcpy Zhao Qiang
2015-05-05  8:32   ` Michael Trimarchi
2015-05-05  9:15     ` qiang.zhao at freescale.com
2015-05-05  9:40       ` Michael Trimarchi
2015-05-06  1:40         ` qiang.zhao at freescale.com
2015-05-06  5:21           ` Michael Trimarchi
2015-06-29 18:30           ` York Sun
2015-08-04 15:45   ` York Sun
2015-06-29 18:27 ` York Sun [this message]
2015-08-04 15:44 ` [U-Boot] [PATCH 1/2] qe: transform parameter to compatible type York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55918E07.6010808@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox