[U-Boot] [PATCH 21/22] sunxi: Kconfig: Enable CONFIG_USB and friends by default on sunxi

Hans de Goede
2015-06-19T09:37:22Z

Hi,

On 19-06-15 09:46, Ian Campbell wrote:
> On Wed, 2015-06-17 at 21:34 +0200, Hans de Goede wrote:
>> Start using the new Kconfig options which are available for most of the
>> USB settings now.
>>
>> This also allows us to use "CONFIG_USB_EHCI_HCD=y" in defconfig files
>> for new boards instead of CONFIG_SYS_EXTRA_OPTIONS="USB_EHCI".
>
> Should there not be a raft of defconfig changes at the same time? Or is
> that nice but not necessary at this stage?

There could be a of defconfig changes at the same time, but it is not
necessary, so I decided to wait with cleaning this up till later.

I would like to first see all the other stuff from CONFIG_SYS_EXTRA_OPTIONS
by Kconfig-ified too, and then we can cleanup all the CONFIG_SYS_EXTRA_OPTIONS
usage in one go.

Regards,

Hans

>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> board/sunxi/Kconfig | 9 +++++++++
>> include/configs/sunxi-common.h | 5 -----
>> 2 files changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
>> index 6a19f85..8d55cd6 100644
>> --- a/board/sunxi/Kconfig
>> +++ b/board/sunxi/Kconfig
>> @@ -594,4 +594,13 @@ config CMD_SETEXPR
>> config CMD_NET
>> default y
>>
>> +config CMD_USB
>> + default y
>> +
>> +config USB
>> + default y
>> +
>> +config USB_STORAGE
>> + default y
>> +
>> endif
>> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
>> index 063abd5..e2371a1 100644
>> --- a/include/configs/sunxi-common.h
>> +++ b/include/configs/sunxi-common.h
>> @@ -338,11 +338,6 @@ extern int soft_i2c_gpio_scl;
>> #define CONFIG_MUSB_PIO_ONLY
>> #endif
>>
>> -#if defined CONFIG_USB_EHCI || defined CONFIG_USB_MUSB_SUNXI
>> -#define CONFIG_CMD_USB
>> -#define CONFIG_USB_STORAGE
>> -#endif
>> -
>> #ifdef CONFIG_USB_KEYBOARD
>> #define CONFIG_CONSOLE_MUX
>> #define CONFIG_PREBOOT
>
>