[U-Boot] [PATCH 01/22] usb: Always declare usb function prototypes

Simon Glass
2015-07-07T18:33:46Z

On 28 June 2015 at 21:44, Simon Glass <sjg@chromium.org> wrote:
> On 17 June 2015 at 13:33, Hans de Goede <hdegoede@redhat.com> wrote:
>> There is no harm in declaring the function prototypes even if nothing
>> implements them, and when CONFIG_DM_USB=y the various usb functions are
>> available regardless of any controller drivers being enabled.
>>
>> This fixes compile warnings due to missing prototypes on ARCHs where
>> the ARCH Kconfig always enables CONFIG_DM_USB and various usb drivers.
>>
>> One could argue that in the case of no controllers CONFIG_DM_USB should not
>> be set, but this problem is typically seen during bringup of boards which
>> do actually have usb controllers.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> Changes in v2:
>> -Simply always define the function prototypes instead of adding yet another
>> condition to the already unwieldly #if def ... || def ... condition
>> ---
>> include/usb.h | 15 ---------------
>> 1 file changed, 15 deletions(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Note: this was already applied to mainline.