[U-Boot] [PATCH 19/22] sunxi: musb: Move musb config and platdata to the sunxi-musb glue

Ian Campbell
2015-06-19T13:31:48Z

On Fri, 2015-06-19 at 11:35 +0200, Hans de Goede wrote:
> Hi,
>
> On 19-06-15 09:43, Ian Campbell wrote:
> > On Wed, 2015-06-17 at 21:34 +0200, Hans de Goede wrote:
> >> Move the musb config and platdata to the sunxi-musb glue, which is where
> >> it really belongs. This is preparation patch for adding device-model
> >> support for the sunxi-musb-host code.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >> ---
> >> arch/arm/include/asm/arch-sunxi/usb_phy.h | 7 +++++++
> >> board/sunxi/board.c | 28 ++-----------------------
> >> drivers/usb/musb-new/sunxi.c | 35 ++++++++++++++++++++++---------
> >> 3 files changed, 34 insertions(+), 36 deletions(-)
> >>
> >> diff --git a/arch/arm/include/asm/arch-sunxi/usb_phy.h b/arch/arm/include/asm/arch-sunxi/usb_phy.h
> >> index 5a9cacb..17d31b8 100644
> >> --- a/arch/arm/include/asm/arch-sunxi/usb_phy.h
> >> +++ b/arch/arm/include/asm/arch-sunxi/usb_phy.h
> >> @@ -19,3 +19,10 @@ void sunxi_usb_phy_power_off(int index);
> >> int sunxi_usb_phy_vbus_detect(int index);
> >> int sunxi_usb_phy_id_detect(int index);
> >> void sunxi_usb_phy_enable_squelch_detect(int index, int enable);
> >> +
> >> +/* Not really phy related, but we have to declare this somewhere ... */
> >
> > I guess arch/arm/include/asm/arch-sunxi/usbc.h isn't any better?
>
> Well we do not have that, and I did not feel it was worth adding yet
> another .h file for just this one function.

Ah, my tree had:

u-boot.git$ wc -l arch/arm/include/asm/arch-sunxi/usbc.h
24 arch/arm/include/asm/arch-sunxi/usbc.h

But it was stale and the file has now gone in sunxi#next.

Ian.