From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Wed, 01 Jul 2015 11:44:11 +0200 Subject: [U-Boot] [PATCH v3 34/54] dm: power: Avoid case-insensitve match for child names In-Reply-To: <1435095556-15924-35-git-send-email-sjg@chromium.org> References: <1435095556-15924-1-git-send-email-sjg@chromium.org> <1435095556-15924-35-git-send-email-sjg@chromium.org> Message-ID: <5593B66B.2040101@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, On 06/23/2015 11:38 PM, Simon Glass wrote: > This is not user input (i.e. from the command line). It should be possible > to get the case correct and avoid the case-insensitive match. This will > help avoid sloppy device tree setups. > > Signed-off-by: Simon Glass > --- > > Changes in v3: None > Changes in v2: None > > drivers/power/pmic/pmic-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/pmic/pmic-uclass.c b/drivers/power/pmic/pmic-uclass.c > index 812ac13..40b5135 100644 > --- a/drivers/power/pmic/pmic-uclass.c > +++ b/drivers/power/pmic/pmic-uclass.c > @@ -55,7 +55,7 @@ int pmic_bind_children(struct udevice *pmic, int offset, > child = NULL; > for (info = child_info; info->prefix && info->driver; info++) { > prefix_len = strlen(info->prefix); > - if (strncasecmp(info->prefix, node_name, prefix_len)) > + if (strncmp(info->prefix, node_name, prefix_len)) > continue; > > debug(" - compatible prefix: '%s'\n", info->prefix); > Tested on: - Odroid U3 (odroid_defconfig) - Sandbox - ut pmic/regulator Tested-by: Przemyslaw Marczak Acked-by: Przemyslaw Marczak Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com