From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Wed, 01 Jul 2015 11:44:27 +0200 Subject: [U-Boot] [PATCH v3 38/54] dm: power: Use debug() for errors in regulator uclass In-Reply-To: <1435095556-15924-39-git-send-email-sjg@chromium.org> References: <1435095556-15924-1-git-send-email-sjg@chromium.org> <1435095556-15924-39-git-send-email-sjg@chromium.org> Message-ID: <5593B67B.4050305@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On 06/23/2015 11:39 PM, Simon Glass wrote: > To reduce unnecessary code size in an uncommon code path, use debug() > where possible(). The driver returns an error which indicates failure. > > Signed-off-by: Simon Glass > --- > > Changes in v3: None > Changes in v2: None > > drivers/power/regulator/regulator-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c > index a2d0b9f..12e141b 100644 > --- a/drivers/power/regulator/regulator-uclass.c > +++ b/drivers/power/regulator/regulator-uclass.c > @@ -262,7 +262,7 @@ static int regulator_post_bind(struct udevice *dev) > if (regulator_name_is_unique(dev, uc_pdata->name)) > return 0; > > - error("\"%s\" of dev: \"%s\", has nonunique value: \"%s\"", > + debug("\"%s\" of dev: \"%s\", has nonunique value: \"%s\"", > property, dev->name, uc_pdata->name); > > return -EINVAL; > Tested on: - Odroid U3 (odroid_defconfig) - Sandbox - ut pmic/regulator Tested-by: Przemyslaw Marczak Acked-by: Przemyslaw Marczak Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com