From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 01 Jul 2015 16:55:43 +0200
Subject: [U-Boot] Marvell Armada XP SATA support
In-Reply-To: <CAOrV_gDWYDQf9QXk1tj8pi+NOj_6OWf9+=cgW0zwg4eeLV-OiA@mail.gmail.com>
References: <CAOrV_gBKTr_dh1ecvCxUfh5GzH0NU30MTy7CFBARPo2LF3AF2Q@mail.gmail.com>	<CAEUhbmW3B9MACO4Ks-8gszkzziHEOfrwWr09s5+GaozHfLcJeQ@mail.gmail.com>	<55895345.9070800@denx.de>	<CAOrV_gDr6ti0wrw2MBivdgf26WHjO7ohhuyCfNdP3fXMbNepGg@mail.gmail.com>	<55923DC6.3000509@denx.de>	<CAOrV_gD2zxb4jfiExHbTxj-n828=wgWHNLhOUXEsXCsgf1Az3Q@mail.gmail.com>	<CAOrV_gBaoaqB=R9BXJTsJAwehcj-6yaye-d+mC-ui-QJtuSZFA@mail.gmail.com>	<5593C377.10402@denx.de>
 <CAOrV_gDWYDQf9QXk1tj8pi+NOj_6OWf9+=cgW0zwg4eeLV-OiA@mail.gmail.com>
Message-ID: <5593FF6F.1020007@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Anton,

On 01.07.2015 15:41, Anton Schubert wrote:
> 2015-07-01 12:39 GMT+02:00 Stefan Roese <sr at denx.de <mailto:sr@denx.de>>:
>
>     Hi Anton,
>
>     On 01.07.2015 12:20, Anton Schubert wrote:
>
>         I figured out my problem was just ATA security. After unlocking
>         the code
>         above works fine for MV78260.
>
>
>     Great. Then please send a patch to the list to add support for SATA
>     on AXP.
>
>     Thanks,
>     Stefan
>
>
> Should i move the mbus init code to mach-mvebu/cpu.c for that purpose?

No, please keep it in the driver. I only moved it into cpu.c since there 
is no MVEBU specific driver in the AHCI/SATA case.

> Additionally, what would you recommend for the MVEBU_SATA_BASE define as
> it would be ambiguous after the a38x patch.

Why not just use the same name/macro?

Thanks,
Stefan