public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Marvell Armada XP SATA support
Date: Wed, 01 Jul 2015 17:19:24 +0200	[thread overview]
Message-ID: <559404FC.3080702@denx.de> (raw)
In-Reply-To: <CAOrV_gALJL2-6cUh5c-r8SEGh+hh02uVmU8CwdFrOe9GFpAhQQ@mail.gmail.com>

Hi Anton,

On 01.07.2015 17:09, Anton Schubert wrote:
>         Additionally, what would you recommend for the MVEBU_SATA_BASE
>         define as
>         it would be ambiguous after the a38x patch.
>
>
>     Why not just use the same name/macro?
>
> I think it would be a bit confusing with MVEBU_SATA0_BASE for A38X and
> MVEBU_SATA_BASE for AXP in the same header. (As I don't have access to
> the A38X Spec I don't know how similar they really are)

Do the addresses differ? If not, then please use the same macro and 
perhaps add a comment, that on AXP this is not AHCI compatible. And on 
A38x it is.

If the addresses differ, I suggest to use a name like:

MVEBU_AXP_SATA_BASE

Thanks,
Stefan

      reply	other threads:[~2015-07-01 15:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23  9:35 [U-Boot] Marvell Armada XP SATA support Anton Schubert
2015-06-23 11:23 ` Bin Meng
2015-06-23 12:38   ` Stefan Roese
2015-06-29 17:01     ` Anton Schubert
2015-06-30  6:57       ` Stefan Roese
2015-06-30  9:28         ` Anton Schubert
2015-07-01 10:20           ` Anton Schubert
2015-07-01 10:39             ` Stefan Roese
2015-07-01 13:41               ` Anton Schubert
2015-07-01 14:55                 ` Stefan Roese
2015-07-01 15:09                   ` Anton Schubert
2015-07-01 15:19                     ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559404FC.3080702@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox