From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 01 Jul 2015 17:19:24 +0200
Subject: [U-Boot] Marvell Armada XP SATA support
In-Reply-To: <CAOrV_gALJL2-6cUh5c-r8SEGh+hh02uVmU8CwdFrOe9GFpAhQQ@mail.gmail.com>
References: <CAOrV_gBKTr_dh1ecvCxUfh5GzH0NU30MTy7CFBARPo2LF3AF2Q@mail.gmail.com>	<CAEUhbmW3B9MACO4Ks-8gszkzziHEOfrwWr09s5+GaozHfLcJeQ@mail.gmail.com>	<55895345.9070800@denx.de>	<CAOrV_gDr6ti0wrw2MBivdgf26WHjO7ohhuyCfNdP3fXMbNepGg@mail.gmail.com>	<55923DC6.3000509@denx.de>	<CAOrV_gD2zxb4jfiExHbTxj-n828=wgWHNLhOUXEsXCsgf1Az3Q@mail.gmail.com>	<CAOrV_gBaoaqB=R9BXJTsJAwehcj-6yaye-d+mC-ui-QJtuSZFA@mail.gmail.com>	<5593C377.10402@denx.de>	<CAOrV_gDWYDQf9QXk1tj8pi+NOj_6OWf9+=cgW0zwg4eeLV-OiA@mail.gmail.com>	<5593FF6F.1020007@denx.de>
 <CAOrV_gALJL2-6cUh5c-r8SEGh+hh02uVmU8CwdFrOe9GFpAhQQ@mail.gmail.com>
Message-ID: <559404FC.3080702@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Anton,

On 01.07.2015 17:09, Anton Schubert wrote:
>         Additionally, what would you recommend for the MVEBU_SATA_BASE
>         define as
>         it would be ambiguous after the a38x patch.
>
>
>     Why not just use the same name/macro?
>
> I think it would be a bit confusing with MVEBU_SATA0_BASE for A38X and
> MVEBU_SATA_BASE for AXP in the same header. (As I don't have access to
> the A38X Spec I don't know how similar they really are)

Do the addresses differ? If not, then please use the same macro and 
perhaps add a comment, that on AXP this is not AHCI compatible. And on 
A38x it is.

If the addresses differ, I suggest to use a name like:

MVEBU_AXP_SATA_BASE

Thanks,
Stefan