U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v3 10/10] spi: cadence_qspi: add device tree binding doc
Date: Thu, 02 Jul 2015 12:12:01 +0200	[thread overview]
Message-ID: <55950E71.7090604@denx.de> (raw)
In-Reply-To: <9026814FBF99304F9FA3AC3FB72F3E2F016C372B@SAFEX1MAIL4.st.com>

Hi Vikas,

On 01.07.2015 00:57, Vikas MANOCHA wrote:
>>> +Cadence QSPI controller device tree bindings
>>> +--------------------------------------------
>>> +
>>> +Required properties:
>>> +- compatible           : should be "cadence,qspi".
>>> +- reg                  : 1.Physical base address and size of SPI registers map.
>>> +                         2. Physical base address & size of NOR Flash.
>>> +- clocks               : Clock phandles (see clock bindings for details).
>>> +- sram-size            : spi controller sram size.
>>
>> ? bus-num
>
> It is not being used in the cadence_qspi driver but used on socfpga
> arch to distinguish between different spi peripherals.
>
> Stefan,
> Can you please comment about it. It is ok to remove it from
> "arch/arm/dts/socfpga.dtsi"

Not sure. Why do we need to remove it? I would prefer to keep it as its 
know to work this way.

BTW: We need to re-sync with the Linux Cadence QSPI NOR driver at some 
time. At least in regard to the device-tree properties. The driver has 
been posted for quite some time now. And I hope it will be accepted 
soon. And as you can see from [1] the bindings / properties differ a bit 
from our currently used ones. So once this driver is accepted in 
kernel.org, we need to re-sync the bindings / dts files again.

Thanks,
Stefan

[1] http://permalink.gmane.org/gmane.linux.drivers.mtd/58159

  reply	other threads:[~2015-07-02 10:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 20:49 [U-Boot] [v3 00/10] spi: cadence_qspi: sram depth from DT & fix for FIFO width Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 01/10] stv0991: enable saving enrironment in spi flash Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 02/10] stv0991: move OF_CONTROL config to defconfig Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 03/10] stv0991: remove define CONFIG_OF_SEPARATE from board file Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 04/10] stv0991: configure clock & pad muxing for qspi Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 05/10] stv0991: enable cadence qspi controller & spi flash Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 06/10] stv0991: configure device tree for cadence qspi & flash Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 07/10] spi: cadence_qspi: move the sram partition in init Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 08/10] spi: cadence_qspi: get sram size from device tree Vikas Manocha
2015-06-30  6:28   ` Jagan Teki
2015-06-29 20:49 ` [U-Boot] [v3 09/10] spi: cadence_qspi: support FIFO width other than 4 bytes Vikas Manocha
2015-06-29 20:49 ` [U-Boot] [v3 10/10] spi: cadence_qspi: add device tree binding doc Vikas Manocha
2015-06-30  6:29   ` Jagan Teki
2015-06-30 22:57     ` Vikas MANOCHA
2015-07-02 10:12       ` Stefan Roese [this message]
2015-07-02 17:42         ` Vikas MANOCHA
2015-07-02 17:48           ` Jagan Teki
2015-07-02 17:52             ` Vikas MANOCHA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55950E71.7090604@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox