From: R, Vignesh <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition
Date: Sat, 4 Jul 2015 18:23:37 +0530 [thread overview]
Message-ID: <5597D751.1020604@ti.com> (raw)
In-Reply-To: <003901d0b598$33d79fd0$9b86df70$@pont@sdcsystems.com>
On 7/3/2015 7:27 PM, Andy Pont wrote:
> Vignesh wrote...
>
> [snip]
>
>> +#define BIT(x) (1 << (x))
>> +
>
> Is this not something that would be better in a global header file somewhere rather than it starting a trend of a per-driver, per-arch, etc. definitions?
I agree there are few per arch defintions.
How about adding it to include/linux/bitops.h as in linux kernel?
Regards
Vignesh
next prev parent reply other threads:[~2015-07-04 12:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 11:16 [U-Boot] [PATCH 00/11] Enable edma support for ti-qspi Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 01/11] sf: allocate cache aligned buffers to copy from flash Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 02/11] env: use cache line aligned memory for flash read Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 03/11] ARM: AM43xx: Add support for disabling clocks in uboot Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 04/11] ARM: OMAP5: " Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 05/11] ARM: OMAP5: Add functions to enable and disable EDMA3 clocks Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 06/11] ARM: AM43XX: " Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 07/11] sf: ops: Add spi_flash_copy_mmap function Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 08/11] spi: ti_qspi: Use DMA to read from qspi flash Vignesh R
2015-07-03 11:42 ` Tom Rini
2015-07-04 12:53 ` R, Vignesh
2015-07-06 5:34 ` Vignesh R
2015-07-09 6:40 ` Vignesh R
2015-07-14 19:02 ` Tom Rini
2015-07-21 12:41 ` R, Vignesh
2015-07-03 11:16 ` [U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition Vignesh R
2015-07-03 13:57 ` Andy Pont
2015-07-04 12:53 ` R, Vignesh [this message]
2015-07-04 15:35 ` Jagan Teki
2015-07-03 11:16 ` [U-Boot] [PATCH 10/11] ARM: dra7xx_evm: Enable EDMA3 in SPL to support DMA on qspi Vignesh R
2015-07-03 11:16 ` [U-Boot] [PATCH 11/11] ARM: am43xx_evm: Enable EDMA3 " Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5597D751.1020604@ti.com \
--to=vigneshr@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox