From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 25/55] dm: pmic: max77686: Correct a few nits
Date: Fri, 10 Jul 2015 13:53:00 +0200 [thread overview]
Message-ID: <559FB21C.4040607@samsung.com> (raw)
In-Reply-To: <1435882592-487-26-git-send-email-sjg@chromium.org>
Hello Simon,
On 07/03/2015 02:16 AM, Simon Glass wrote:
> The driver name should not have a space in it. Also the regulator names
> should match the case of the device tree. Fix these problems.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> drivers/power/pmic/max77686.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/pmic/max77686.c b/drivers/power/pmic/max77686.c
> index 3523b4a..dc5a54a 100644
> --- a/drivers/power/pmic/max77686.c
> +++ b/drivers/power/pmic/max77686.c
> @@ -17,8 +17,8 @@
> DECLARE_GLOBAL_DATA_PTR;
>
> static const struct pmic_child_info pmic_children_info[] = {
> - { .prefix = "ldo", .driver = MAX77686_LDO_DRIVER },
> - { .prefix = "buck", .driver = MAX77686_BUCK_DRIVER },
> + { .prefix = "LDO", .driver = MAX77686_LDO_DRIVER },
> + { .prefix = "BUCK", .driver = MAX77686_BUCK_DRIVER },
> { },
> };
>
> @@ -84,7 +84,7 @@ static const struct udevice_id max77686_ids[] = {
> };
>
> U_BOOT_DRIVER(pmic_max77686) = {
> - .name = "max77686 pmic",
> + .name = "max77686_pmic",
> .id = UCLASS_PMIC,
> .of_match = max77686_ids,
> .bind = max77686_bind,
>
Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>
This change is ok, but could you please consider Odroid U3
(exynos4412-odroid.dts) within this patch set?
Regards
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2015-07-10 11:53 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 0:15 [U-Boot] [PATCH 00/55] dm: exynos: Driver model improvements leading to spring support Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 01/55] dm: core: Support finding a device by phandle Simon Glass
2015-07-27 23:28 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 02/55] dm: i2c: Add a message debug function Simon Glass
2015-07-03 6:52 ` Heiko Schocher denx
2015-07-27 23:28 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 03/55] dm: i2c: Correct comment nits in dm_i2c_reg_read/write() Simon Glass
2015-07-03 6:53 ` Heiko Schocher denx
2015-07-27 23:28 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 04/55] dm: i2c: Move definitions to the top of the header file Simon Glass
2015-07-03 6:55 ` Heiko Schocher denx
2015-07-27 23:28 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 05/55] dm: i2c: Add a function to transfer messages Simon Glass
2015-07-03 6:58 ` Heiko Schocher denx
2015-07-27 23:28 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 06/55] dm: i2c: Add support for multiplexed I2C buses Simon Glass
2015-07-05 6:10 ` Heiko Schocher
2015-07-06 16:38 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 07/55] exynos: i2c: Correct bug in pinmux selection Simon Glass
2015-07-05 6:15 ` Heiko Schocher
2015-07-06 15:27 ` Simon Glass
2015-07-07 1:36 ` Minkyu Kang
2015-07-08 2:38 ` Simon Glass
2015-07-10 1:43 ` Minkyu Kang
2015-07-10 1:46 ` Simon Glass
2015-07-10 8:56 ` Przemyslaw Marczak
2015-07-10 12:14 ` Minkyu Kang
2015-07-07 6:51 ` Przemyslaw Marczak
2015-07-03 0:15 ` [U-Boot] [PATCH 08/55] i2c: Add a mux for GPIO-based I2C bus arbitration Simon Glass
2015-07-05 6:43 ` Heiko Schocher
2015-07-06 16:38 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 09/55] exynos: i2c: Fix code style with ReadWriteByte() Simon Glass
2015-07-05 6:45 ` Heiko Schocher
2015-07-27 23:29 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 10/55] exynos: i2c: Tidy up the driver model code Simon Glass
2015-07-06 5:40 ` Heiko Schocher
2015-07-27 23:28 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 11/55] exynos: dts: Sync up I2C ports with the kernel Simon Glass
2015-07-10 11:51 ` Przemyslaw Marczak
2015-07-27 23:29 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 12/55] exynos: dts: Add PMIC and regulator definitions Simon Glass
2015-07-10 11:51 ` Przemyslaw Marczak
2015-07-27 23:29 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 13/55] exynos: dts: Support EC tunnel and main TPS65090 regulator Simon Glass
2015-07-27 23:29 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 14/55] dm: cros_ec: Convert the I2C tunnel code to use driver model Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 15/55] cros_ec: Support the LDO access method used by spring Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 16/55] exynos: serial: Refactor init code for debug UART Simon Glass
2015-07-27 23:29 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 17/55] exynos: Add debug UART support for Samsung S5P serial Simon Glass
2015-07-27 23:29 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 18/55] exynos: Enable the debug UART in SPL Simon Glass
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 19/55] dm: gpio: Add support for setting a GPIO's pull direction Simon Glass
2015-07-05 4:55 ` Masahiro Yamada
2015-07-06 16:39 ` Simon Glass
2015-07-06 17:20 ` Masahiro Yamada
2015-07-06 17:33 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 20/55] dm: exynos: gpio: Support pull-up/down in GPIOs Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 21/55] dm: power: Add a new driver for the TPS65090 PMIC Simon Glass
2015-07-10 11:52 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:15 ` [U-Boot] [PATCH 22/55] dm: power: Add support for TPS65090 FETs Simon Glass
2015-07-10 11:52 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 23/55] dm: power: Add support for the S5M8767 PMIC Simon Glass
2015-07-10 11:52 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 24/55] dm: power: Add support for S5M8767 regulators Simon Glass
2015-07-10 11:52 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 25/55] dm: pmic: max77686: Correct a few nits Simon Glass
2015-07-10 11:53 ` Przemyslaw Marczak [this message]
2015-07-27 23:30 ` Simon Glass
2015-07-28 6:19 ` Przemyslaw Marczak
2015-08-03 14:02 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 26/55] dm: pmic: Correct the pmic_reg_write() implementation Simon Glass
2015-07-10 11:53 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 27/55] dm: power: max77686: Correct BUCK register access Simon Glass
2015-07-10 11:53 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 28/55] dm: pmic: max77686: Support all BUCK regulators Simon Glass
2015-07-10 11:53 ` Przemyslaw Marczak
2015-07-30 2:05 ` Simon Glass
2015-07-30 8:22 ` Przemyslaw Marczak
2015-08-03 14:05 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 29/55] dm: power: Don't return an error when regulators are not autoset Simon Glass
2015-07-10 11:54 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 30/55] dm: pmic: Display the regulator limits on error Simon Glass
2015-07-10 11:54 ` Przemyslaw Marczak
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 31/55] dm: video: Add support for video bridges Simon Glass
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 32/55] dm: video: Add support for the Parade PS8622/625 bridge Simon Glass
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 33/55] dm: video: Add support for the NXP PTN3460 bridge Simon Glass
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 34/55] exynos: spi: Convert the timeout to debug() Simon Glass
2015-07-27 23:30 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 35/55] exynos: Correct return value in exynos_mmc_init() Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 36/55] exynos: Add support for the DisplayPort hotplug detect Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 37/55] exynos: video: Correct debug output Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 38/55] exynos: Tidy up CPU frequency display Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 39/55] dm: gpio: Check a GPIO is valid before using it Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 40/55] dts: exynos: snow: Add memory layout description Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 41/55] dts: exynos: pit: Add a new node for the parade video bridge driver Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 42/55] dts: exynos: snow: Add a new node for the NXP " Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 43/55] exynos: dts: Drop the old TPS65090 I2C node Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 44/55] exynos: Add common board code for exynos5 boards that use device tree Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 45/55] exynos: Enable new features for exynos5 boards Simon Glass
2015-07-10 11:55 ` Przemyslaw Marczak
2015-07-28 16:29 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 46/55] exynos: Remove unneeded device tree control #ifdefs Simon Glass
2015-07-27 23:31 ` Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 47/55] exynos: config: Move common options to the common headers and tidy up Simon Glass
2015-07-10 11:56 ` Przemyslaw Marczak
2015-07-03 0:16 ` [U-Boot] [PATCH 48/55] exynos: Drop old exynos5420-specific board code Simon Glass
2015-07-10 11:56 ` Przemyslaw Marczak
2015-07-03 0:16 ` [U-Boot] [PATCH 49/55] exynos: Drop old exynos5250-specific " Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 50/55] power: Remove old TPS65090 drivers Simon Glass
2015-07-10 11:56 ` Przemyslaw Marczak
2015-07-03 0:16 ` [U-Boot] [PATCH 51/55] cros_ec: Remove the old tunnel code Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 52/55] video: Remove the old parade driver Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 53/55] dts: Drop unused compatible ID for the NXP video bridge Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 54/55] exynos: video: Remove non-device-tree code Simon Glass
2015-07-03 0:16 ` [U-Boot] [PATCH 55/55] exynos: Add support for spring Simon Glass
2015-07-20 14:19 ` [U-Boot] [PATCH 00/55] dm: exynos: Driver model improvements leading to spring support Simon Glass
2015-07-22 4:52 ` Minkyu Kang
2015-07-23 2:08 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559FB21C.4040607@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox