From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Fri, 10 Jul 2015 16:30:20 +0200 Subject: [U-Boot] [PATCH] musb: set MUSB speed based on CONFIG In-Reply-To: <1436534204-26853-2-git-send-email-samuel.egli@siemens.com> References: <1436534204-26853-1-git-send-email-samuel.egli@siemens.com> <1436534204-26853-2-git-send-email-samuel.egli@siemens.com> Message-ID: <559FD6FC.4010606@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 10-07-15 15:16, Samuel Egli wrote: > From: Bin Liu > > Do not config MUSB to highspeed mode if CONFIG_USB_GADGET_DUALSPEED > is not set, in which case Ether gadget only operates in fullspeed. > > Note: > This patch is necessary for devices like some siemens boards > that allow only FULL SPEED USB 1.1, e.g. DFU download. > > Signed-off-by: Bin Liu > Reviewed-by: Tom Rini > Tested-by: Samuel Egli > CC: Marek Vasut > CC: Heiko Schocher > CC: Daniel Mack > CC: Roger Meier Nack this breaks highspeed mode on boards which use the musb in host mode, and thus do not set CONFIG_USB_GADGET_DUALSPEED. Regards, Hans > --- > drivers/usb/musb-new/musb_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/musb-new/musb_core.c b/drivers/usb/musb-new/musb_core.c > index 242cc30..4edd6d7 100644 > --- a/drivers/usb/musb-new/musb_core.c > +++ b/drivers/usb/musb-new/musb_core.c > @@ -942,7 +942,9 @@ void musb_start(struct musb *musb) > > /* put into basic highspeed mode and start session */ > musb_writeb(regs, MUSB_POWER, MUSB_POWER_ISOUPDATE > +#ifdef CONFIG_USB_GADGET_DUALSPEED > | MUSB_POWER_HSENAB > +#endif > /* ENSUSPEND wedges tusb */ > /* | MUSB_POWER_ENSUSPEND */ > ); > -- > 1.7.10.4 > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >