From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 10 Jul 2015 17:12:15 +0200 Subject: [U-Boot] [PATCH] musb: set MUSB speed based on CONFIG In-Reply-To: <27E9275BC1C8554E840881B19B62BE421A9ED3@DENBGAT9EI1MSX.ww902.siemens.net> References: <1436534204-26853-1-git-send-email-samuel.egli@siemens.com> <1436534204-26853-2-git-send-email-samuel.egli@siemens.com> <559FD6FC.4010606@redhat.com> <559FD87C.7060905@redhat.com> <27E9275BC1C8554E840881B19B62BE421A9ED3@DENBGAT9EI1MSX.ww902.siemens.net> Message-ID: <559FE0CF.60202@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Samuel, Am 10.07.2015 um 16:50 schrieb Egli, Samuel: > Hi Hans, > >> -----Original Message----- >> From: Hans de Goede [mailto:hdegoede at redhat.com] >> Sent: Freitag, 10. Juli 2015 16:37 >> To: Egli, Samuel; marex at denx.de >> Cc: u-boot at lists.denx.de; trini at konsulko.com; Bin Liu; Meier, Roger; >> Daniel Mack >> Subject: Re: [U-Boot] [PATCH] musb: set MUSB speed based on CONFIG >> >> Hi, >> >> On 10-07-15 16:30, Hans de Goede wrote: >>> Hi, >>> >>> On 10-07-15 15:16, Samuel Egli wrote: >>>> From: Bin Liu >>>> >>>> Do not config MUSB to highspeed mode if CONFIG_USB_GADGET_DUALSPEED >>>> is not set, in which case Ether gadget only operates in fullspeed. >>>> >>>> Note: >>>> This patch is necessary for devices like some siemens boards that >>>> allow only FULL SPEED USB 1.1, e.g. DFU download. >>>> >>>> Signed-off-by: Bin Liu >>>> Reviewed-by: Tom Rini >>>> Tested-by: Samuel Egli >>>> CC: Marek Vasut >>>> CC: Heiko Schocher >>>> CC: Daniel Mack >>>> CC: Roger Meier >>> >>> Nack this breaks highspeed mode on boards which use the musb in host >>> mode, and thus do not set CONFIG_USB_GADGET_DUALSPEED. >> >> p.s. >> >> Given that you want to use this as a hack to work around the broken pcb >> design of your board I suggest adding a new option for this > > Well, lets not discuss the "broken" pcb design. It seems that wiring protection > is not that common. Unfortunately, such a protection is too expensive for > USB High speed :-(. > >> titled: CONFIG_USB_MUSB_NO_HIGHSPEED and then do: >> >> +#ifndef CONFIG_USB_MUSB_NO_HIGHSPEED >> | MUSB_POWER_HSENAB >> +#endif >> > This would be good enough. The point is indeed to limit it to full speed. > >> Using CONFIG_USB_GADGET_DUALSPEED for this seems wrong, since this has >> nothing to do with enabling dualspeed mode for the gadget code really. > > I agree that the name is confusing. Yes, I vote for Hans suggestion. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany