public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vz@mleia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand: lpc32xx: add SLC NAND controller support
Date: Wed, 15 Jul 2015 11:49:01 +0300	[thread overview]
Message-ID: <55A61E7D.8000001@mleia.com> (raw)
In-Reply-To: <20150715090509.243306f6@lilith>

Hello Albert,

On 15.07.2015 10:05, Albert ARIBAUD wrote:
> Hello Vladimir,
> 
> On Tue, 14 Jul 2015 23:23:57 +0300, Vladimir Zapolskiy <vz@mleia.com>
> wrote:
>> The change adds support of LPC32xx SLC NAND controller.
>> 
>> LPC32xx SoC has two different mutually exclusive NAND controllers 
>> to communicate with single and multiple layer chips.
>> 
>> This simple driver allows to specify NAND chip timings and defines
>>  custom read_buf()/write_buf() operations, because access to 8-bit 
>> data register must be 32-bit aligned.
>> 
>> Support of hardware ECC calculation is not implemented (data 
>> correction is always done by software), since it requires a working
>> DMA engine.
>> 
>> The driver can be included to an SPL image.
> 
> This is needed for an upcoming new board support patch, right?

you are correct, I plan to extend current support of devkit3250 board.

> If so, then I suggest you put together all patches for this new
> board in a single series. This will make it clear(er) you're not
> adding dead code here.
> 

I got the point, I will be able to complete board specific changes today
tonight and send them for review.

Please let me ask you for one more advice, if I want to add peripherals
support on the board (by the way thank you for your drivers) and SPL
image building support, both changes touch defconfig and board config
header files. Should I split these changes into separate ones or is one
"board support extension" patch preferred?

--
With best wishes,
Vladimir

  reply	other threads:[~2015-07-15  8:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 20:23 [U-Boot] [PATCH] nand: lpc32xx: add SLC NAND controller support Vladimir Zapolskiy
2015-07-15  7:05 ` Albert ARIBAUD
2015-07-15  8:49   ` Vladimir Zapolskiy [this message]
2015-07-15  9:21     ` Albert ARIBAUD
2015-07-15 19:23       ` LEMIEUX, SYLVAIN
2015-07-15 20:21         ` Albert ARIBAUD
2015-07-16  0:19         ` Vladimir Zapolskiy
2015-07-16 19:38           ` LEMIEUX, SYLVAIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A61E7D.8000001@mleia.com \
    --to=vz@mleia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox