From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes
Date: Tue, 21 Jul 2015 09:56:36 -0600 [thread overview]
Message-ID: <55AE6BB4.5060200@wwwdotorg.org> (raw)
In-Reply-To: <1437471398-17457-1-git-send-email-mirza.krak@hostmobility.com>
On 07/21/2015 03:36 AM, Mirza Krak wrote:
> From: Mirza Krak <mirza.krak@hostmobility.com>
>
> Add the device tree node for the SPI controllers found on Tegra20 SOCs.
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> + spi at 7000d400 {
> + compatible = "nvidia,tegra20-slink";
> + reg = <0x7000d400 0x200>;
> + interrupts = <0 59 0x04>;
> + nvidia,dma-request-selector = <&apbdma 15>;
That property doesn't seem to exist in the kernel DT, and "resets",
"reset-names", "dmas", "dma-names" are missing. I'd suggest simply
cutting/pasting from the kernel DT to make sure they stay in sync.
interrupts and clocks should also use the #defines to provide named
constants for better readability and the same consistency reasons.
next prev parent reply other threads:[~2015-07-21 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 9:36 [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes Mirza Krak
2015-07-21 15:56 ` Stephen Warren [this message]
2015-07-21 20:28 ` Simon Glass
2015-07-21 20:39 ` Mirza Krak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE6BB4.5060200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox