public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Murali Karicheri <m-karicheri2@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 4/8] configs: ti_armv7_keystone2: start using armv7_common
Date: Wed, 22 Jul 2015 11:19:29 -0400	[thread overview]
Message-ID: <55AFB481.2020806@ti.com> (raw)
In-Reply-To: <1437237636-8946-5-git-send-email-nm@ti.com>

On 07/18/2015 12:40 PM, Nishanth Menon wrote:
> Try to maintain as much commonality by conditionally including stuff
> in armv7_common as necessary and removing the common defines from
> keystone2 header.

>
>   /* U-Boot Build Configuration */
>   #define CONFIG_SKIP_LOWLEVEL_INIT	/* U-Boot is a 2nd stage loader */
> -#define CONFIG_SYS_NO_FLASH		/* that is, no *NOR* flash */
> -#define CONFIG_SYS_CONSOLE_INFO_QUIET
>   #define CONFIG_BOARD_EARLY_INIT_F
> -#define CONFIG_SYS_THUMB_BUILD

One thing I see is THUMB build is only enabled for SPL build in 
ti_armv7_common.h. With this transition, regular build will not be using 
THUMB build anymore.  This is not right. Please fix it. Many platforms 
configs such as tbs2910.h, colibri_vf.h, highbank.h etc has this enabled 
for both builds as this will reduce the image size.

>
>   /* SoC Configuration */

-- 
Murali Karicheri
Linux Kernel, Keystone

  reply	other threads:[~2015-07-22 15:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-18 16:40 [U-Boot] [PATCH V3 0/8] configs: make keystone2 config to start using arm_v7_common header Nishanth Menon
2015-07-18 16:40 ` [U-Boot] [PATCH V3 1/8] configs: split ti_armv7_common into a omap generic header Nishanth Menon
2015-07-22 15:35   ` Tom Rini
2015-07-18 16:40 ` [U-Boot] [PATCH V3 2/8] board: ks2_evm: get rid of bogus CONFIG_LINUX_BOOT_PARAM_ADDR Nishanth Menon
2015-07-22 15:35   ` Tom Rini
2015-07-18 16:40 ` [U-Boot] [PATCH V3 3/8] configs: rename ks2_evm into ti_armv7_keystone2 Nishanth Menon
2015-07-22 15:23   ` Murali Karicheri
2015-07-22 15:24   ` Murali Karicheri
2015-07-22 15:35   ` Tom Rini
2015-07-18 16:40 ` [U-Boot] [PATCH V3 4/8] configs: ti_armv7_keystone2: start using armv7_common Nishanth Menon
2015-07-22 15:19   ` Murali Karicheri [this message]
2015-07-22 15:28     ` Tom Rini
2015-07-18 16:40 ` [U-Boot] [PATCH V3 5/8] configs: ti_armv7_keystone2: switch addresses to generic addresses Nishanth Menon
2015-07-22 15:22   ` Murali Karicheri
2015-07-22 15:35   ` Tom Rini
2015-07-18 16:40 ` [U-Boot] [PATCH V3 6/8] ti_armv7_keystone2: switch to using kernel zImage Nishanth Menon
2015-07-22 15:21   ` Murali Karicheri
2015-07-22 15:35   ` Tom Rini
2015-07-18 16:40 ` [U-Boot] [PATCH V3 7/8] configs: k2*_evm: rename skernel binary names to generated file names Nishanth Menon
2015-07-22 15:21   ` Murali Karicheri
2015-07-22 15:35   ` Tom Rini
2015-07-18 16:40 ` [U-Boot] [PATCH V3 8/8] configs: keystone2: remove distro specific ramdisk name Nishanth Menon
2015-07-22 15:20   ` Murali Karicheri
2015-07-22 15:32   ` Tom Rini
2015-07-22 15:33     ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AFB481.2020806@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox