[U-Boot] [PATCH V3 4/8] configs: ti_armv7_keystone2: start using armv7_common

Tom Rini
2015-07-22T15:28:31Z

On Wed, Jul 22, 2015 at 11:19:29AM -0400, Murali Karicheri wrote:
> On 07/18/2015 12:40 PM, Nishanth Menon wrote:
> >Try to maintain as much commonality by conditionally including stuff
> >in armv7_common as necessary and removing the common defines from
> >keystone2 header.
>
> >
> > /* U-Boot Build Configuration */
> > #define CONFIG_SKIP_LOWLEVEL_INIT /* U-Boot is a 2nd stage loader */
> >-#define CONFIG_SYS_NO_FLASH /* that is, no *NOR* flash */
> >-#define CONFIG_SYS_CONSOLE_INFO_QUIET
> > #define CONFIG_BOARD_EARLY_INIT_F
> >-#define CONFIG_SYS_THUMB_BUILD
>
> One thing I see is THUMB build is only enabled for SPL build in
> ti_armv7_common.h. With this transition, regular build will not be
> using THUMB build anymore. This is not right. Please fix it. Many
> platforms configs such as tbs2910.h, colibri_vf.h, highbank.h etc
> has this enabled for both builds as this will reduce the image size.

Good point. Lets just whack thumb on for all platforms (so after the
patch to make things include ti_armv7_omap.h, add that in). Thanks!

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150722/53f7eafa/attachment.sig>