public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: mvebu: add multiple usb-hostcontroller support for AXP
Date: Thu, 23 Jul 2015 14:35:08 +0200	[thread overview]
Message-ID: <55B0DF7C.9020502@denx.de> (raw)
In-Reply-To: <1437654313-32161-1-git-send-email-anton.schubert@gmx.de>

Hi Anton,

(added Marek to Cc, as he's the USB custodian)

On 23.07.2015 14:25, Anton Schubert wrote:
> This patch adds support for multiple hostcontrollers to the ehci-marvell driver
> and enables all 3 usb-hcs on the db-mv784mp-gp board.
>
> It depends on the initial Armada XP usb support patch from Stefan.
>
> Signed-off-by: Anton Schubert <anton.schubert@gmx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>

Thanks. But this patch will not apply once my latest patches from 
yesterday and today are applied. Please see below:

> ---
>   drivers/usb/host/ehci-marvell.c | 23 ++++++++++++-----------
>   include/configs/db-mv784mp-gp.h |  1 +
>   2 files changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-marvell.c b/drivers/usb/host/ehci-marvell.c
> index 826e7f7..6548cb2 100644
> --- a/drivers/usb/host/ehci-marvell.c
> +++ b/drivers/usb/host/ehci-marvell.c
> @@ -22,7 +22,8 @@
>   DECLARE_GLOBAL_DATA_PTR;
>
>   #define rdl(off)	readl(MVUSB0_BASE + (off))
> -#define wrl(off, val)	writel((val), MVUSB0_BASE + (off))
> +#define wrl(port, off, val)	writel((val), MVUSB0_BASE + (off) + \
> +	((port) << 12))

I've removed the wrl() accessor funtion from this file:

https://patchwork.ozlabs.org/patch/498431/

So please rebase this patch on top of this version. You can add my:

Reviewed-by: Stefan Roese <sr@denx.de>

then as well. :)

Thanks,
Stefan

      reply	other threads:[~2015-07-23 12:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 12:25 [U-Boot] [PATCH] arm: mvebu: add multiple usb-hostcontroller support for AXP Anton Schubert
2015-07-23 12:35 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B0DF7C.9020502@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox