From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 23 Jul 2015 14:35:08 +0200 Subject: [U-Boot] [PATCH] arm: mvebu: add multiple usb-hostcontroller support for AXP In-Reply-To: <1437654313-32161-1-git-send-email-anton.schubert@gmx.de> References: <1437654313-32161-1-git-send-email-anton.schubert@gmx.de> Message-ID: <55B0DF7C.9020502@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Anton, (added Marek to Cc, as he's the USB custodian) On 23.07.2015 14:25, Anton Schubert wrote: > This patch adds support for multiple hostcontrollers to the ehci-marvell driver > and enables all 3 usb-hcs on the db-mv784mp-gp board. > > It depends on the initial Armada XP usb support patch from Stefan. > > Signed-off-by: Anton Schubert > Cc: Stefan Roese > Cc: Luka Perkov Thanks. But this patch will not apply once my latest patches from yesterday and today are applied. Please see below: > --- > drivers/usb/host/ehci-marvell.c | 23 ++++++++++++----------- > include/configs/db-mv784mp-gp.h | 1 + > 2 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/usb/host/ehci-marvell.c b/drivers/usb/host/ehci-marvell.c > index 826e7f7..6548cb2 100644 > --- a/drivers/usb/host/ehci-marvell.c > +++ b/drivers/usb/host/ehci-marvell.c > @@ -22,7 +22,8 @@ > DECLARE_GLOBAL_DATA_PTR; > > #define rdl(off) readl(MVUSB0_BASE + (off)) > -#define wrl(off, val) writel((val), MVUSB0_BASE + (off)) > +#define wrl(port, off, val) writel((val), MVUSB0_BASE + (off) + \ > + ((port) << 12)) I've removed the wrl() accessor funtion from this file: https://patchwork.ozlabs.org/patch/498431/ So please rebase this patch on top of this version. You can add my: Reviewed-by: Stefan Roese then as well. :) Thanks, Stefan